Search code examples
asp.net-mvcmodel-bindingaction-filter

Understanding ASP.NET MVC Lifecycle: Why is Model not available in ActionFilter?


I have created the following Custom ActionFilter, when I try to access the Model in the following code, it is null:

public class CustomPermissionCheckAttribute : ActionFilterAttribute
{
    public override void OnActionExecuting(ActionExecutingContext context)
    {
        OrganisationBaseController orgBaseController = context.Controller as Controller;
        var vm = ((Controller)context.Controller).ViewData.Model as MyViewModel; // null

        // check if current user has permission to vm.OrganisationId

        base.OnActionExecuting(context);
    }
}

I am trying to understand why the Model is null? According to ASP.NET MVC Lifecycle, ActionFilters are executed after Model Binder, so I am not sure why the Model is not available?

enter image description here


This is how I am register the above Action Filter:

[HttpPost]
[CustomPermissionCheck]
public ActionResult UpdateBranch(MyViewModel myViewModel)
{
    if (ModelState.IsValid)
    {
        // so something 
    }
    return View();
}

Solution

  • Could try this to access the request model:

    MyViewModel vm = context.ActionParameters.Values.OfType<MyViewModel>().SingleOrDefault();
    

    How to get current model in action filter