Search code examples
csssassgulpminify

Running gulp commands one by one results in different output than running them in gulp.series. Why?


Below is my gulpfile. I am trying to generate minified css from scss and then rename it using gulp-rev. Running gulp clean:assets then gulp scss then gulp css works perfectly. But running gulp build does not do the task. The minified css gets stored in ./assets/css but the renamed css is not getting stored in ./public/assets

const gulp = require('gulp');
//gulp sass converts sass to css
const sass = require('gulp-sass');
//cssnano converts css to minified form
const cssnano = require('gulp-cssnano');
//rev renames the assets by appending content hash to filenames so that the browser treats it as a new asset if content is changed
const rev = require('gulp-rev');
const path = require('path');
const del = require('del');

gulp.task('clean:assets', function(done){
    del.sync('./public/assets');
    del.sync('./assets/css');
    done();
});

gulp.task('scss', function(done){
    gulp.src('./assets/scss/**/*.scss')
    .pipe(sass())
    .pipe(cssnano())
    .pipe(gulp.dest('./assets/css'))
    done();
});

gulp.task('css', function(done){
    gulp.src('./assets/css/**/*.css', {base: path.join(process.cwd(), 'assets')})
    .pipe(rev())
    .pipe(gulp.dest('./public/assets/'))
    .pipe(rev.manifest('public/assets/rev-manifest.json',{
        base: process.cwd()+'./public/assets',
        merge: true
    }))
    .pipe(gulp.dest('./public/assets'));
    done();
});

gulp.task('build', gulp.series('clean:assets', 'scss', 'css'), function(done){
    done(); 
})

Solution

  • gulp.task('scss', ()=> {
        return new Promise((resolve, reject) => {
            return gulp.src('./assets/scss/**/*.scss')
                .pipe(sass())
                .pipe(cssnano())
                .pipe(gulp.dest('./assets/css'))
                .on('end', resolve)
                .on('error', reject);
        });
    });
    

    Changed the scss task to above to get it working. Refer to https://stackoverflow.com/a/53937286/7374508