Search code examples
androidandroid-fragmentsandroid-viewpagerandroid-architecture-componentsandroid-architecture-navigation

Navigation Architecture Component: FragmentManager is already executing transactions


I have BottomNavigationView with 3 main fragments: A, B and C. When I'm trying to open FragmentC a second time in any sequence using BottomNavigationView, I see an error: FragmentManager is already executing transactions

BUT without setupViewPager() line everything works fine and I cat open FragmentC more than once. Otherwise, an error is displayed.

I can't understand what's happening. Please, I really need your help.

setViews() it's a function defined in BaseFragment and invoked in onViewCreated()

FragmentC

class FragmentC: BaseFragment() {

    override val menuResId: Nothing? = null
    override val contentResId = R.layout.fragment_c
    override val baseToolbar = R.id.toolbar

    override fun setViews(view: View) {
        setupViewPager()   <----- error
    }

    private fun setupViewPager() {
        val viewPagerAdapter = ViewPagerAdapter(baseActivity.supportFragmentManager).apply {
            addFragment(FragmentE(), "E")
            addFragment(FragmentF(), "F")
        }
        viewPager.adapter = viewPagerAdapter     <----- error
        tabLayout.setupWithViewPager(viewPager)
    }
}

ViewPagerAdapter

class ViewPagerAdapter(fm: FragmentManager) : FragmentStatePagerAdapter(fm, BEHAVIOR_RESUME_ONLY_CURRENT_FRAGMENT) {

    private val titleList : MutableList<String> = ArrayList()
    private val fragmentList : MutableList<Fragment> = ArrayList()

    override fun getItem(position: Int): Fragment {
        return fragmentList[position]
    }

    override fun getCount(): Int {
        return fragmentList.size
    }

    fun addFragment(fragment: Fragment, title: String){
        titleList.add(title)
        fragmentList.add(fragment)
    }

    override fun getPageTitle(position: Int): CharSequence? {
        return titleList[position]
    }
}

Error

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.example.project, PID: 20461
    java.lang.IllegalStateException: FragmentManager is already executing transactions
        at androidx.fragment.app.FragmentManager.ensureExecReady(FragmentManager.java:1778)
        at androidx.fragment.app.FragmentManager.execSingleAction(FragmentManager.java:1814)
        at androidx.fragment.app.BackStackRecord.commitNowAllowingStateLoss(BackStackRecord.java:303)
        at androidx.fragment.app.FragmentStatePagerAdapter.finishUpdate(FragmentStatePagerAdapter.java:270)
        at androidx.viewpager.widget.ViewPager.setAdapter(ViewPager.java:513)
        at com.example.project.views.communication.CommunicationFragment.setupViewPager(CommunicationFragment.kt:26)
        at com.example.project.views.communication.CommunicationFragment.setViews(CommunicationFragment.kt:18)
        at com.example.project.views.base.BaseFragment.onViewCreated(BaseFragment.kt:37)
        at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:332)
        at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1187)
        at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1356)
        at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:1434)
        at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1497)
        at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:2625)
        at androidx.fragment.app.FragmentManager.dispatchActivityCreated(FragmentManager.java:2577)
        at androidx.fragment.app.Fragment.performActivityCreated(Fragment.java:2722)
        at androidx.fragment.app.FragmentStateManager.activityCreated(FragmentStateManager.java:346)
        at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1188)
        at androidx.fragment.app.FragmentManager.addAddedFragments(FragmentManager.java:2224)
        at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1997)
        at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1953)
        at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1849)
        at androidx.fragment.app.FragmentManager$4.run(FragmentManager.java:413)
        at android.os.Handler.handleCallback(Handler.java:873)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:193)
        at android.app.ActivityThread.main(ActivityThread.java:6669)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

Maybe someone has any ideas why an error might occur?


Solution

  • Use childFragmentManager instead of supportFragmentManager Then, either override method saveState like this

    override fun saveState(): Parcelable {
        return null
    }
    

    or change FragmentStatePagerAdapter to FragmentPagerAdapter