Search code examples
angularmockingangular-routertestbed

Angular test how to mock ActivatedRoute data


I have a real big problem with mocking ActivatedRoute data property. No matter what I am doing all it ends up with error message : Error: <spyOnProperty> : Property data does not have access type get. Moving stub const to separate mock class also not solving the issue. I have found that this should be straight forward but I am struggling with this for a few days now.

Component

@Component({
  selector: 'app-notifications',
  templateUrl: './notifications.component.html',
  styleUrls: ['./notifications.component.css']
})
export class NotificationsComponent implements OnInit {
  notifications: NotificationEntry[];

  constructor(
    private route: ActivatedRoute,
    private modalService: ModalService,
    private messageBoxService: MessageBoxService,
    private notificationsService: NotificationsService
  ) {}

  ngOnInit() {
    this.route.data.subscribe(
      (data: { notifications: NotificationEntry[] }) => {
        this.notifications = data.notifications;
      }
    );
  }
}

Component.spec

describe('NotificationsComponent', () => {
  let component: NotificationsComponent;
  let fixture: ComponentFixture<NotificationsComponent>;

  const registryVersionBasicData = new RegistryVersionBasicData(
    false,
    'versionId',
    new JsonDate('Unspecified', 631894104000000000),
    'user',
    'comment'
  )

  const notifications = new NotificationEntry(
    new JsonDate('Unspecified', 631894104000000000),
    'summary',
    'message',
    NotificationEntityType.StressScenario,
    'instance name',
    'instance key',
    registryVersionBasicData,
    'additional information')

  const notificationsArray = [notifications]

  beforeEach(() => {
    const activatedRouteStub = { data: of({ notifications: notificationsArray }) };
    const modalServiceStub = {};
    const messageBoxServiceStub = {};
    const notificationsServiceStub = {};

    TestBed.configureTestingModule({
      schemas: [NO_ERRORS_SCHEMA],
      declarations: [NotificationsComponent, OrderPipe, RenderDatePipe, VersionInfoPipe],
      providers: [
        { provide: ActivatedRoute, useValue: activatedRouteStub },
        { provide: ModalService, useValue: modalServiceStub },
        { provide: MessageBoxService, useValue: messageBoxServiceStub },
        { provide: NotificationsService, useValue: notificationsServiceStub },
      ]
    }).compileComponents();

    fixture = TestBed.createComponent(NotificationsComponent);
    component = fixture.componentInstance;
  });

  it('can load instance', () => {
    expect(component).toBeTruthy();
  });

  describe('ngOnInit', () => {
    it('should get notifications entry', () => {
      const activatedRouteStub = TestBed.get(ActivatedRoute);
      spyOnProperty(activatedRouteStub, 'data')

      component.ngOnInit();

      expect(component.notifications).toEqual(notificationsArray)
    });
  });
});

Solution

  • import { ComponentFixture, TestBed } from '@angular/core/testing';
    import { NO_ERRORS_SCHEMA } from '@angular/core';
    import { NotificationsComponent } from './notifications.component';
    import { ActivatedRoute } from '@angular/router';
    import { ModalService, MessageBoxService, NotificationsService, NotificationEntry, JsonDate, NotificationEntityType, RegistryVersionBasicData } from 'src/app/shared';
    import { OrderPipe } from 'ngx-order-pipe';
    import { RenderDatePipe } from 'src/app/shared/pipes/renderdate.pipe';
    import { VersionInfoPipe } from 'src/app/shared/pipes/versioninfo.pipe';
    import { of } from 'rxjs';
    
    fdescribe('NotificationsComponent', () => {
      let component: NotificationsComponent;
      let fixture: ComponentFixture<NotificationsComponent>;
    
      const registryVersionBasicData = new RegistryVersionBasicData(
        false,
        'versionId',
        new JsonDate('Unspecified', 631894104000000000),
        'user',
        'comment'
      );
    
      const notifications = new NotificationEntry(
        new JsonDate('Unspecified', 631894104000000000),
        'summary',
        'message',
        NotificationEntityType.StressScenario,
        'instance name',
        'instance key',
        registryVersionBasicData,
        'additional information');
    
    
      const route = { data: of({ notifications: [notifications] }) };
    
    
      beforeEach(() => {
        const modalServiceStub = {};
        const messageBoxServiceStub = {};
        const notificationsServiceStub = {};
    
        TestBed.configureTestingModule({
          schemas: [NO_ERRORS_SCHEMA],
          declarations: [NotificationsComponent, OrderPipe, RenderDatePipe, VersionInfoPipe],
          providers: [
            { provide: ActivatedRoute, useValue: route },
            { provide: ModalService, useValue: modalServiceStub },
            { provide: MessageBoxService, useValue: messageBoxServiceStub },
            { provide: NotificationsService, useValue: notificationsServiceStub },
          ]
        });
    
        fixture = TestBed.createComponent(NotificationsComponent);
        component = fixture.componentInstance;
      });
    
      it('can load instance', () => {
        expect(component).toBeTruthy();
      });
    
      describe('ngOnInit', () => {
        it('should get notifications entry', () => {
          component.ngOnInit();
          expect(component.notifications).toEqual([notifications]);
        });
      });
    });
    

    Simplest possible solution. Use:

    const route = { data: of({ notifications: [notifications] }) };
    

    .. and then, use this value in component providers:

    { provide: ActivatedRoute, useValue: route }
    

    .. as a primitive mock for ActivatedRoute. Then, your test case can look like this (no TestBed needed):

      describe('ngOnInit', () => {
        it('should get notifications entry', () => {
          component.ngOnInit();
          expect(component.notifications).toEqual([notifications]);
        });
      });