UICollectionView not scrolling correctly

Question

I am populating a UICollectionView where the cells are full screen and they scroll horizontally. The correct data is displayed on the screen, but when I press my button to print out the current price, it keeps on printing the price for the next indexPath. I believe I am doing something incorrect when it comes to scrolling. If pagingEnabled is either turned on or off it also makes no difference.

   class PostCell: UICollectionViewCell {
let containerView:UIView = {
       let view = UIView()
       view.translatesAutoresizingMaskIntoConstraints = false
       view.clipsToBounds = true
       return view
   }()

let priceLabel:UILabel = {
         let label = UILabel()
         label.font = UIFont.boldSystemFont(ofSize: 20)
         label.text = "price"
         label.textColor = .black
         label.translatesAutoresizingMaskIntoConstraints = false
         return label
     }()
let myButton: UIButton = {
    let button = UIButton(type: .system)
    button.titleLabel?.font = UIFont.systemFont(ofSize: 18)
    button.backgroundColor =  .red 
    return button

}()
func set(name: String, brand: String, price: String){
       priceLabel.text = price

   }
  override init(frame: CGRect) {
     super.init(frame: frame)
    self.contentView.addSubview(containerView)
    containerView.addSubview(priceLabel)
    containerView.addSubview(myButton)
    setupCellConstraints()
    }
     private func setupCellConstraints(){

       containerView.anchor(top: contentView.topAnchor, left: contentView.leftAnchor, bottom: contentView.bottomAnchor, right: contentView.rightAnchor, paddingTop: 0, paddingLeft: 0, paddingBottom: 0, paddingRight: 0, width: 0, height: 0)

       nameLabel.anchor(top: containerView.topAnchor, left: nil, bottom: nil, right: nil, paddingTop: 50, paddingLeft: 0, paddingBottom: 0, paddingRight: 0, width: 0, height: 0)
    brandLabel.anchor(top: nameLabel.bottomAnchor, left: nil, bottom: nil, right: nil, paddingTop: 50, paddingLeft: 0, paddingBottom: 0, paddingRight: 0, width: 0, height: 0)
    priceLabel.anchor(top: brandLabel.bottomAnchor, left: nil, bottom: nil, right: nil, paddingTop: 50, paddingLeft: 0, paddingBottom: 0, paddingRight: 0, width: 0, height: 0)
    myButton.anchor(top: priceLabel.bottomAnchor, left: nil, bottom: nil, right: nil, paddingTop: 60, paddingLeft: 0, paddingBottom: 0, paddingRight: 0, width: 70, height: 70)

   }
    required init?(coder aDecoder: NSCoder) {
        fatalError("init(coder:) has not been implemented")
    }
}



   class CollectionViewController: UICollectionViewController, UICollectionViewDelegateFlowLayout {

 let cellId = "cellId"
 var itemsArr = [Item]()
     init() {
       super.init(collectionViewLayout: UICollectionViewFlowLayout())
   }
   required init?(coder: NSCoder) {
       fatalError("init(coder:) has not been implemented")
   }

  private var collectionViewFlowLayout: UICollectionViewFlowLayout {
    return collectionViewLayout as! UICollectionViewFlowLayout
}
override func viewDidLoad() {
    parseData()
    collectionView.showsHorizontalScrollIndicator = false
    collectionView.showsVerticalScrollIndicator = false
    collectionViewFlowLayout.minimumLineSpacing = 0
    self.collectionView.isPagingEnabled = true
    if let layout = collectionView.collectionViewLayout as? UICollectionViewFlowLayout {
        layout.scrollDirection = .horizontal
    }

    collectionView?.register(PostCell.self, forCellWithReuseIdentifier: cellId)

} 

 func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, sizeForItemAt indexPath: IndexPath) -> CGSize {

    return CGSize(width: view.frame.width, height: view.frame.height)
   }

override func collectionView(_ collectionView: UICollectionView, numberOfItemsInSection section: Int) -> Int {
    return itemsArr.count
}

@objc func buttonPressed(){
    print(price)
}

var price: String = ""
override func collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) -> UICollectionViewCell {

      let cell = collectionView.dequeueReusableCell(withReuseIdentifier: cellId, for: indexPath) as! PostCell
    let item = itemsArr[indexPath.row]]
    price = item.price
    cell.set(name: item.name, brand: item.brand, price: item.price)
    cell.myButton.addTarget(self, action: #selector(buttonPressed), for: .touchUpInside)
      print(item)
      return cell
  }

Answer 1

You have only one 'price' variable and it keeps last visible cell's data. Your logic is incorrect. You must have a 'price' value for every cell.

Here is another suggestion for you;

// we capture the tag of the button and tag points the index of the array.
@objc func buttonPressed(_ sender : UIButton){
    let item = itemArr[sender.tag]
    print(item)
}

// var price: String = "" // that variable is meaningless.
override func collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) -> UICollectionViewCell {

    let cell = collectionView.dequeueReusableCell(withReuseIdentifier: cellId, for: indexPath) as! PostCell
    let item = itemsArr[indexPath.row]]
    // price = item.price // that line is meaningless. 
    cell.set(name: item.name, brand: item.brand, price: item.price)
    cell.myButton.tag = indexPath.row // added that line.
    cell.myButton.addTarget(self, action: #selector(buttonPressed(:)), for: .touchUpInside) // changed that line little bit.
    print(item)
    return cell
}