Search code examples
androidviewflipper

Android ViewFlipper not flipping


I have a ViewFlipper which should react to a fling gesture, but it does not.

Activity

@Override
public void onCreate(Bundle savedInstanceState) {
    ...
    listView = this.getListView();
    detector = new GestureDetector(this, new FlingGestureListener(listView));
    ...
}

FlingGestureListener

public boolean onFling(MotionEvent e1, MotionEvent e2, float velocityX, float velocityY) {
    int pos = source.pointToPosition(Math.round(e1.getX()), Math.round(e1.getY()));
    View v = source.getChildAt(pos - source.getFirstVisiblePosition());
    System.out.println("fling: x=" + velocityX + " y=" + velocityY);
    try {
        IFlingable flingable = (IFlingable) v;
        if(velocityY > -200 && velocityY < 200) {
            if(velocityX < 0)
                flingable.fling(IFlingable.RIGHT_TO_LEFT);
            else if(velocityX > 0)
                flingable.fling(IFlingable.LEFT_TO_RIGHT);
        }
    } catch(Exception e) {}
    return false;
}

View with ViewFlipper which implements IFlingable

public void fling(int direction) {
    System.out.println("flip: " + direction);
    switch(direction) {
        case IFlingable.LEFT_TO_RIGHT:
            System.out.println("piep");
            GUIHelper.setAnimationSlideLeftToRight(context, switcher);
            switcher.showNext();
            break;
        case IFlingable.RIGHT_TO_LEFT:
            System.out.println("pup");
            GUIHelper.setAnimationSlideRightToLeft(context, switcher);
            switcher.showPrevious();
            break;
    }
}

Layout

<ViewFlipper android:id="@+id/viewSwitcher"
    android:layout_height="wrap_content"
    android:layout_width="match_parent" android:layout_weight="1"     
    android:inAnimation="@anim/slide_in_left" 
    android:outAnimation="@anim/slide_out_right">
        <LinearLayout android:layout_height="wrap_content" 
           android:layout_width="match_parent" android:orientation="vertical">
             ...
        </LinearLayout>
      ...
    </ViewFlipper>

Log

fling: x=2542.3613 y=95.877945
flip: 0
piep

I get the right log messages so the showNext() on the ViewFlipper gets executed but it does not change its view on the gui. Am I missing something? I have another layout with a ViewSwitcher instead of the Flipper and that one works.

EDIT:

Here are the missing classes:

public class GUIHelper {
... 

public static void setAnimationSlideLeftToRight(Context context, ViewAnimator switcher) {
    Animation in = AnimationUtils.loadAnimation(context, R.anim.slide_in_left);
    Animation out = AnimationUtils.loadAnimation(context, R.anim.slide_out_right);
    switcher.setInAnimation(in);
    switcher.setOutAnimation(out);
}

public static void setAnimationSlideRightToLeft(Context context, ViewAnimator switcher) {
    Animation in = AnimationUtils.loadAnimation(context, R.anim.slide_in_right);
    Animation out = AnimationUtils.loadAnimation(context, R.anim.slide_out_left);
    switcher.setInAnimation(in);
    switcher.setOutAnimation(out);
}

...
}

public interface IFlingable {

    public static final int LEFT_TO_RIGHT = 0;
    public static final int RIGHT_TO_LEFT = 1;

    public void fling(int direction, boolean fling);

}

Solution

  • Hello this is the running swipe code on listView just as your xml I have placed a ListView with parent LinearLayout in ViewFlipper

    import android.app.Activity;
    import android.os.Bundle;
    
    import android.view.GestureDetector;
    
    import android.view.GestureDetector.SimpleOnGestureListener;
    
    import android.view.MotionEvent;
    
    import android.view.View;
    import android.view.animation.Animation;
    import android.view.animation.AnimationUtils;
    import android.widget.AdapterView;
    import android.widget.ArrayAdapter;
    import android.widget.ListView;
    import android.widget.Toast;
    import android.widget.ViewFlipper;
    
    import android.widget.AdapterView.OnItemClickListener;
    
    
    public class MainActivity extends Activity {
    
        private static final int SWIPE_MIN_DISTANCE = 120;
        private static final int SWIPE_MAX_OFF_PATH = 250;
        private static final int SWIPE_THRESHOLD_VELOCITY = 200;
        private GestureDetector gestureDetector;
        View.OnTouchListener gestureListener;
        private Animation slideLeftIn;
        private Animation slideLeftOut;
        private Animation slideRightIn;
        private Animation slideRightOut;
        private ViewFlipper viewFlipper;
        private ListView lv;
        private String[] city = { "Indore", "Bhopal", "Khargone", "Ujjain",
            "Nasik", "Pune", "Delhi", "Mumbai", "Noida", "Hyderabad",
            "Banglore", "Ajmer", "Goa", "Jaipur", "Nagpur", "" };
        private String[] country = { "India", "Bhutan", "Kuwait", "USA", };
    
        @Override
        public void onCreate(Bundle savedInstanceState) {
            super.onCreate(savedInstanceState);
            setContentView(R.layout.main_layout);
            lv = (ListView) findViewById(R.id.List01);
            ListView lv2 = (ListView) findViewById(R.id.List02);
    
            viewFlipper = (ViewFlipper) findViewById(R.id.flipper);
            slideLeftIn = AnimationUtils.loadAnimation(this, R.anim.slide_left_in);
            slideLeftOut = AnimationUtils
                    .loadAnimation(this, R.anim.slide_left_out);
            slideRightIn = AnimationUtils
                    .loadAnimation(this, R.anim.slide_right_in);
            slideRightOut = AnimationUtils.loadAnimation(this,
                    R.anim.slide_right_out);
    
            gestureDetector = new GestureDetector(new MyGestureDetector());
            gestureListener = new View.OnTouchListener() {
                public boolean onTouch(View v, MotionEvent event) {
                    if (gestureDetector.onTouchEvent(event)) {
                        return true;
                    }
                    return false;
                }
            };
            lv.setAdapter(new ArrayAdapter<String>(this,
                    android.R.layout.simple_list_item_1, city));
            lv2.setAdapter(new ArrayAdapter<String>(this,
                    android.R.layout.simple_list_item_1, country));
            lv.setOnItemClickListener(new OnItemClickListener() {
                public void onItemClick(AdapterView arg0, View view, int position,
                        long id) {
                    // user clicked a list item, make it "selected"
                    Toast.makeText(getBaseContext(), "Item Clicked",
                            Toast.LENGTH_SHORT).show();
                    // selectedAdapter.setSelectedPosition(position);
                }
            });
            lv2.setOnItemClickListener(new OnItemClickListener() {
                public void onItemClick(AdapterView arg0, View view, int position,
                        long id) {
                    // user clicked a list item, make it "selected"
                    Toast.makeText(getBaseContext(), "Item List2 Clicked",
                            Toast.LENGTH_SHORT).show();
                    // selectedAdapter.setSelectedPosition(position);
                }
            });
        }
    
        class MyGestureDetector extends SimpleOnGestureListener {
            @Override
            public boolean onFling(MotionEvent e1, MotionEvent e2, float velocityX,
                    float velocityY) {
                try {
                    if (Math.abs(e1.getY() - e2.getY()) > SWIPE_MAX_OFF_PATH)
                        return false;
                    // right to left swipe
                    if (e1.getX() - e2.getX() > SWIPE_MIN_DISTANCE
                            && Math.abs(velocityX) > SWIPE_THRESHOLD_VELOCITY) {
                        viewFlipper.setInAnimation(slideLeftIn);
                        viewFlipper.setOutAnimation(slideLeftOut);
                        viewFlipper.showNext();
                    } else if (e2.getX() - e1.getX() > SWIPE_MIN_DISTANCE
                            && Math.abs(velocityX) > SWIPE_THRESHOLD_VELOCITY) {
                        viewFlipper.setInAnimation(slideRightIn);
                        viewFlipper.setOutAnimation(slideRightOut);
                        viewFlipper.showPrevious();
                    }
                } catch (Exception e) {
                    // nothing
                }
                return false;
            }
        }
    
        @Override
        public boolean onTouchEvent(MotionEvent event) {
            if (gestureDetector.onTouchEvent(event))
                return true;
            else
                return false;
        }
    }
    

    Included the layout(main_layout) that is used.....

     <?xml version="1.0" encoding="UTF-8"?>
    <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
        android:id="@+id/linearLayout1"
        android:layout_width="fill_parent"
        android:layout_height="fill_parent"
        android:orientation="vertical" >
    
        <LinearLayout
            android:layout_width="fill_parent"
            android:layout_height="wrap_content" >
    
            <Button
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:text="Do not Click Just swipe on remaining area" />
        </LinearLayout>
    
        <ViewFlipper
            xmlns:android="http://schemas.android.com/apk/res/android"
            android:id="@+id/flipper"
            android:layout_width="fill_parent"
            android:layout_height="fill_parent" >
    
            <LinearLayout
                android:id="@+id/ViewFlipper01"
                android:layout_width="fill_parent"
                android:layout_height="fill_parent"
                android:orientation="vertical" >
    
                <ListView
                    android:id="@+id/List01"
                    android:layout_width="fill_parent"
                    android:layout_height="wrap_content" >
                </ListView>
            </LinearLayout>