Power shell For Loop not Looping

Question

So the output works fine but I'm having an issue with it only outputing the last line it runs. Is there anyway to check for loops to test in the future?

but i have a list of ip address and im trying to check if the firewall in windows is enabled or disabled. They are on one LARGE (300+ workgroup). Any help in getting this to loop properly would be appreciated. Security and other things are not a concern cause i have other scripts that run fine. And i dont get any errors. just the single output.

ive already tried moving the array and that didn't help. im thinking it could be the PSCustomObject part as i'm just starting to learn these. Or could it be my input and output formats are different and that's causing issues??

clear
$ComputerList = get-content C:\Users\Administrator\Desktop\DavidsScripts\TurnOffFirewall\input.txt
$Status = @(
foreach ($Computer in $ComputerList) {

netsh -r $Computer advfirewall show currentprofile state})[3] -replace 'State' -replace '\s' 


$Object = [PSCustomObject]@{
    Computer = $Computer
    Firewall = $Status
}

Write-Output $Object
$Object | Export-Csv -Path "C:\FirewallStatus.csv" -Append -NoTypeInformation

Answer 1

Your previous code was not escaping the loop and was only adding the last computer in the loop to the object.

The best way I have found, is to make a temp object and add it to an array list then export that. Much nicer.

$ComputerList = get-content C:\Users\Administrator\Desktop\DavidsScripts\TurnOffFirewall\input.txt
$collectionVariable = New-Object System.Collections.ArrayList

ForEach ($Computer in $ComputerList) {
    # Create temp object
    $temp = New-Object System.Object
    # Add members to temp object
    $temp | Add-Member -MemberType NoteProperty -Name "Computer" -Value $Computer
    $temp | Add-Member -MemberType NoteProperty -Name "Firewall" -Value $((netsh -r $Computer advfirewall show currentprofile state)[3] -replace 'State' -replace '\s')
    # Add the temp object to ArrayList
    $collectionVariable.Add($temp)
}

Write-Output $collectionVariable
$collectionVariable | Export-Csv -Path "C:\FirewallStatus.csv" -Append -NoTypeInformation