Search code examples
wpfdata-bindinglistboxwpfdatagrid

How to make ListBox editable when bound to a List<string>?


Edit: The basic problem is binding a List to ListBox(or any other control). So I am editing the question.

I bound a list of string to a ListBox as below. However when I change the contents of the textbox it is not changing the string in the source list.Why?

  public partial class MainWindow : Window
{
    List<string> _nameList = null;

    public List<string> NameList
    {
        get
        {
            if (_nameList == null)
            {
                _nameList = new List<string>();
            }
            return _nameList;
        }
        set
        {
            _nameList = value;
        }
    }
    public MainWindow()
    {
        NameList.Add("test1");
        NameList.Add("test2");
        InitializeComponent();
    }

And the XAML

 <ListBox Grid.Row="0" Grid.Column="0" DataContext="{Binding ElementName=main}" ItemsSource="{Binding NameList}">
        <ListBox.ItemTemplate>
            <DataTemplate>
                <TextBox Text="{Binding .,Mode=OneWayToSource ,  UpdateSourceTrigger=PropertyChanged}"/>
            </DataTemplate>
        </ListBox.ItemTemplate>
    </ListBox>

Solution

  • The DataContext of each ListBoxItem is the string itself, so the path of your binding is empty (.). TwoWay and OneWayToSource bindings require a path, since you can't just replace the current DataContext. So you need to wrap your string in an object that exposes the string as a property:

    public class StringItem
    {
        public string Value { get; set; }
    }
    

    Expose the strings as a list of StringItem:

    public partial class MainWindow : Window
    {
        List<StringItem> _nameList = null;
    
        public List<StringItem> NameList
        {
            get
            {
                if (_nameList == null)
                {
                    _nameList = new List<StringItem>();
                }
                return _nameList;
            }
            set
            {
                _nameList = value;
            }
        }
        public MainWindow()
        {
            NameList.Add(new StringItem { Value = "test1" });
            NameList.Add(new StringItem { Value = "test2" });
            InitializeComponent();
        }
    

    And bind to the Value property:

    <ListBox Grid.Row="0" Grid.Column="0" DataContext="{Binding ElementName=main}" ItemsSource="{Binding NameList}">
        <ListBox.ItemTemplate>
            <DataTemplate>
                <TextBox Text="{Binding Value, UpdateSourceTrigger=PropertyChanged}"/>
            </DataTemplate>
        </ListBox.ItemTemplate>
    </ListBox>
    

    Note that StringItem will also need to implement INotifyPropertyChanged so that bindings are automatically updated. You should also expose the list as an ObservableCollection<T> rather than a List<T>