Search code examples
c#linq-to-sqlnullreferenceexception

Sum() causes exception instead of returning 0 when no rows

I have this code (ok, I don't, but something similar :p)

    var dogs = Dogs.Select(ø => new Row
    {
            Name = ø.Name,
            WeightOfNiceCats = ø.Owner
              .Cats
              .Where(æ => !æ.Annoying)
              .Sum(æ => æ.Weight),
    });

Here I go through all dogs and sum up the weight (into a non-nullable decimal) of all not-annoying cats which has the same owner as the dog. Of course, pretty much all cats are annoying, so I get this error:

The null value cannot be assigned to a member with type System.Decimal which is a non-nullable value type.

None of the fields or foreign keys used can be null. So the error happens when the Where clause returns no cats, which it often does. But how can I solve this? I want it to return 0 when that happens. Tried with a DefaultIfEmpty() after the Where clause, but then I get this error:

Object reference not set to an instance of an object.

Which I guess is understandable. I tried to add a ?? after the Sum, but then it wont compile because of this error:

Operator '??' cannot be applied to operands of type 'decimal' and 'decimal'

Which also makes sense of course. So what can I do? Would be nice if the Sum thing just returned 0 when there was nothing to sum. Or a SumOrZero statement of some sort. Would it be difficult to make a SumOrZero method that worked with Linq2SQL?

Solution

  • This is what I ended up with for now:

    .Sum(æ => (decimal?) æ.Weight) ?? 0.0M,

    This works like a charm.

    I would still prefer to have a SumOrZero I could use, which would work exactly like the regular Sum except it would never return null for any reason. Like the others have noted, this would be pretty easy to make for IEnumerable but a bit more icky to create for IQueryable so it would work with Linq2SQL, etc. So I will just leave it at that for now. Although if someone is bored one day and do write a SumOrZero for IQueryable which works with Linq2SQL for all the numeric types, please do let me know :D