Form ShowDialog won't load image in picture box

Question

When I refresh my form with SHOWDIALOG my image doesn't load in my picture-box but if i refresh with only SHOW it works fine.

I want to be able to refresh with SHOWDIALOG and still have my picture load method work.

I have tried clearing data-bindings of both picture-box and the brows button.

private void formrefresh()
{
     FoodItem FoodItem = new FoodItem();
     FoodItem.ShowDialog();
     this.Close();           
}

public void GetImage()
{
     OpenFileDialog BrowseImage = new OpenFileDialog();

     BrowseImage.Filter = "Image Files(*.jpg; *.gif;)|*.jpg; *.gif";

     if (BrowseImage.ShowDialog() == DialogResult.OK)
     {
          TextBox t = 
               Application.OpenForms["FoodItem"].Controls["imagePath"] as TextBox;
          t.Text = BrowseImage.FileName;
          filenametext = BrowseImage.FileName;
          PictureBox p = Application.OpenForms["FoodItem"].Controls["foodImage"] as PictureBox;

          p.Image = new Bitmap(BrowseImage.FileName);
     }

}

      private void BrowsImage_Click(object sender, EventArgs e)
      {
        GetFoodImage image = new GetFoodImage();

        image.GetImage();
     }

Answer 1

Finding forms (Application.OpenForms) is not a very good approach to use. Try to avoid that if possible. For example, there can be complications if there are multiple instances of a certain Form and you will have to find the exact instance you want to update.

It doesn't make much sense to use a Library to GetImage in your example. If you really need it in a separate Class Library, just return the path. Just return the image path from GetImage method and set the PictureBox from FoodImage.

private void formrefresh()
{
    FoodItem foodItem = new FoodItem();
     foodItem.ShowDialog();
     this.Close();           
}

private void BrowsImage_Click(object sender, EventArgs e)
{
  GetFoodImage image = new GetFoodImage();
  var imagePath = image.GetImage();
  this.foodImage.Image = new Bitmap(imagePath);
  this.imagePath.Text = imagePath;
 }

 public string GetImage(FoodItem foodItem)
 {
     OpenFileDialog BrowseImage = new OpenFileDialog();

     BrowseImage.Filter = "Image Files(*.jpg; *.gif;)|*.jpg; *.gif";

     if (BrowseImage.ShowDialog() == DialogResult.OK)
     {
           return BrowseImage.FileName;
     }        

     return "";
  }