Search code examples
reactjsreact-state-management

React onChange is not updating on input change


I am trying to update my state with an onChange on my input. Currently, onChange on triggers when I press enter. How would I go about updating my state without having to press enter?

  onChange(e, key) {
    const re = /^[0-9\b]+$/;
    if (e.target.value === "" || re.test(e.target.value)) {
      this.setState({ [key]: Number(e.target.value) });
    }
  }

  inputFigureRow(title, amount, key) {
    return (
      <div style={styles.benchMarkRow}>
        <div style={styles.titleRow}>{title}</div>
        <input
          key={key}
          style={styles.inputValueLeft}
          value={amount}
          onChange={e => this.onChange(e, key)}
        />
        <div style={styles.valueRight}>${amount}</div>
      </div>
    );
  }

  renderContent() {
    return (
      <div style={styles.root}>
          <div style={styles.benchMarkContainer}>
            {this.titleRow()}
            {this.inputFigureRow(
              "Sales Target",
              this.state.salesBenchMarkTarget,
              "salesBenchMarkTarget"
            )}
      </div>
    );
  }

  render({}, state) {
    return this.renderContent(state);
  }

Solution

  • Use onKeyDown handler on your input instead of onChange. If you need to wait for the last character, you'll need to introduce a debounce interval, e.g https://blog.flowandform.agency/debounce-in-react-fc5ed305a0e8