Search code examples
c#incrementunreachable-code

increment unreachable in for loop in c# method


I've got this unreachable code in this for loop

public IActionResult List(int id) {
    for (id = 0; id <= 1000; id++) {
        var fil = _repoFil.GetById(id).Result;
        var listafiliali = new List<FilialeVM>();

        foreach (var filiale in fil) {
            var filialeVM = _mapper.Map<FilialeVM>(fil);
            listafiliali.Add(filialeVM);
        }

        return View(listafiliali);
    }

    return View();
}

the increment id++ is unreachable


Solution

  • return your View AFTER your loop finished

    public IActionResult List(int id) {
        var listafiliali = new List<FilialeVM>();
    
        for (id = 0; id <= 1000; id++) {
            var fil = _repoFil.GetById(id).Result;            
            foreach (var filiale in fil) {
                var filialeVM = _mapper.Map<FilialeVM>(fil);
                listafiliali.Add(filialeVM);
            }            
        }
    
        if(listafiliali.Count > 0)
           return View(listafiliali);
    
        return View();
    }