C# I'm having trouble with a dice game where I need to increment a value every time a user plays a game and then print it back to them

Question

I have a dice game which holds two dice and what happens is that one game will go through and then the user will be asked if they want to play again. If, for example, they said yes three times then when they say no at the end to exit the game, they'll get an output telling them how many times they played the game. I'm having trouble coming up with the code for it.

I don't have much experience using parameters and return types(this is a beginner assignment) but I currently have a counter which adds 1. The problem is that it starts at 0 and goes to 1, and then stays there.

Here's the code I have that runs through the game:

namespace MajorAssignment1
{
    class MainClass
    {
        public static void Main(string[] args)
        {
            Console.WriteLine("Hey! Welcome to Ray's Dice Game! Let's Start");
            Console.WriteLine();
            EvenOrOdds();

        }

        public static void EvenOrOdds()
        {

            Random rnd = new Random();

            int die1 = rnd.Next(1, 10);
            int die2 = rnd.Next(1, 10);

            Console.WriteLine("Die 1 = {0} and Die 2 = {1}", die1, die2);
            Console.WriteLine();
            Console.WriteLine("You Rolled {0} and {1}", die1, die2);
            Console.WriteLine();

            if ((die1 + die2) % 2 == 0)
            {
                Console.WriteLine("Evens are better than odd.");
                Console.WriteLine();
            }
            if ((die1 + die2) % 2 > 0 )
            {
                Console.WriteLine("Odds are still cool.");
                Console.WriteLine();
            }


            Console.WriteLine("Do you want to play again? Please enter in all caps YES or NO");
            String UserInput = Console.ReadLine();
            var Counter = 0;
            if (UserInput == "YES")
            {
                EvenOrOdds();

                Counter = Counter + 1;
            }
            else
            {
                Console.WriteLine("The number of times the dice was thrown is:" + Counter);
                Console.WriteLine();
            }



        }

        public static void Outro()
        { 
                Console.WriteLine("Thanks for playing! Come again!");
                Console.WriteLine();

        }
    }
}

Answer 1

Problem with your code is that you are calling EvenOrOdds() recursively, and counter never increments. Moreover, you are doing simple things in a complicated way, I have simplified few things.

Working code:

using System;
public class diceCounter
{
    public static void Main(string[] args)
    {
        String UserInput;
        int Counter =1;
        Console.WriteLine("Hey! Welcome to Ray's Dice Game! Let's Start");
        Console.WriteLine();
        do
        {
            EvenOrOdds();
            Console.WriteLine("Do you want to play again? Please enter in all caps YES or NO");
            UserInput = Console.ReadLine();
            if (UserInput.Equals("YES"))
            {
                Counter++;
                EvenOrOdds();
            }
        }while(!(UserInput.Equals("NO")));

        Console.WriteLine("The number of times the dice was thrown is: " + Counter);
        Outro();
    }

    public static void EvenOrOdds()
    {
        Random rnd = new Random();
        int die1 = rnd.Next(1, 10);
        int die2 = rnd.Next(1, 10);

        Console.WriteLine("Die 1 = {0} and Die 2 = {1}", die1, die2);
        Console.WriteLine();
        Console.WriteLine("You Rolled {0} and {1}", die1, die2);
        Console.WriteLine();

        if ((die1 + die2) % 2 == 0)
        {
            Console.WriteLine("Evens are better than odd.");
            Console.WriteLine();
        }
        if ((die1 + die2) % 2 > 0 )
        {
            Console.WriteLine("Odds are still cool.");
            Console.WriteLine();
        }

    }

    public static void Outro()
    { 
        Console.WriteLine("\nThanks for playing! Come again!\n");
    }
}