Search code examples
c++forward-declaration

Invalid use of incomplete type struct, even with forward declaration

I'm aware of circular dependencies, but even with forward declarations I get this area. What am I doing wrong?

// facility.h
class Area;

class Facility {
public:
    Facility();
    Area* getAreaThisIn();
    void setAreaThisIsIn(Area* area);
private:
    Area* __area;
};

// facility.cpp
#include "facility.h"
#include "area.h"
{ ... }

// area.h
class Facility;
class Area {
public:
    Area(int ID);
    int getId();

private:
    std::list<Facility*> _facilities;
};

// area.cpp
#include "area.h"
#include "facility.h"

So this compiles fine, but if I do

// foo.h
#include "facility.h"
class Foo { .. };

// foo.cpp
#include "foo.h"
void Foo::function() {
    Facility* f = new Facility();
    int id = f->getAreaThisIsIn()->getId();

When I get invalid use of incomplete type struct Area

Solution

  • For Facility* f = new Facility(); you need a full declaration, not just forward declaration.