Search code examples
postgresqldatabase-performancesql-execution-planpostgresql-performance

Simple yet slow SQL query with PostgreSQL


I have two tables I want to join:

CREATE TABLE public."order" (
    id uuid NOT NULL,
    side varchar(4) NOT NULL,
    product varchar(7) NOT NULL,
    price numeric(18,8) NOT NULL,
    close_time timestamp NULL,
    CONSTRAINT order_pkey PRIMARY KEY (id)
);
CREATE TABLE public.order_history (
    id serial NOT NULL,
    amount numeric(18,8) NOT NULL,
    "time" timestamp NOT NULL,
    order_id uuid NOT NULL,
    CONSTRAINT order_history_pkey PRIMARY KEY (id),
    CONSTRAINT order_history_order_id_fkey FOREIGN KEY (order_id) REFERENCES "order"(id)
);
CREATE INDEX order_history_order_id ON public.order_history USING btree (order_id);
CREATE INDEX order_history_time_idx ON public.order_history USING btree ("time");

My query is pretty simple, but it's taking literally minutes on my HDD (a friend of mine stores the same DB on a SSD and clearly it's faster, but it's still way beyond a reasonable time I'm willing to wait):

select
    "t1"."id",
    "t1"."side",
    "t1"."price",
    "t1"."close_time",
    "t2"."time",
    "t2"."amount"
from
    "order" as "t1"
inner join "order_history" as "t2" on
    ("t2"."order_id" = "t1"."id")
where
    ((("t2"."time" <= '2018-03-28 08:00:00')
    and (("t1"."close_time" > '2018-03-28 07:00:00')
    or ("t1"."close_time" is null)))
    and ("t1"."product" = 'BTC-USD'))
order by
    "t2"."time"

Here's the EXPLAIN(ANALYZE, BUFFERS) output:

Gather Merge  (cost=3293333.15..3673129.97 rows=3255174 width=47) (actual time=195630.667..195668.246 rows=83766 loops=1)
  Workers Planned: 2
  Workers Launched: 2
  Buffers: shared hit=346185 read=948128, temp read=402275 written=402089
  ->  Sort  (cost=3292333.13..3296402.10 rows=1627587 width=47) (actual time=193748.573..193751.027 rows=27922 loops=3)
        Sort Key: t2."time"
        Sort Method: quicksort  Memory: 4853kB
        Buffers: shared hit=346185 read=948128, temp read=402275 written=402089
        ->  Hash Join  (cost=1315861.90..3074345.01 rows=1627587 width=47) (actual time=65363.240..193703.738 rows=27922 loops=3)
              Hash Cond: (t1.id = t2.order_id)
              Buffers: shared hit=346172 read=948127, temp read=402275 written=402089
              ->  Parallel Seq Scan on "order" t1  (cost=0.00..1293501.00 rows=11021971 width=34) (actual time=0.122..78296.478 rows=8629896 loops=3)
                    Filter: (((close_time > '2018-03-28 07:00:00'::timestamp without time zone) OR (close_time IS NULL)) AND ((product)::text = 'BTC-USD'::text))
                    Rows Removed by Filter: 19019229
                    Buffers: shared hit=13 read=775079
              ->  Hash  (cost=1079028.57..1079028.57 rows=12248346 width=29) (actual time=65107.372..65107.372 rows=12358141 loops=3)
                    Buckets: 524288  Batches: 32  Memory Usage: 27473kB
                    Buffers: shared hit=346071 read=173036, temp written=218295
                    ->  Bitmap Heap Scan on order_history t2  (cost=229265.25..1079028.57 rows=12248346 width=29) (actual time=2951.352..61701.142 rows=12358141 loops=3)
                          Recheck Cond: ("time" <= '2018-03-28 08:00:00'::timestamp without time zone)
                          Heap Blocks: exact=139266
                          Buffers: shared hit=346071 read=173036
                          ->  Bitmap Index Scan on order_history_time_idx  (cost=0.00..226203.16 rows=12248346 width=0) (actual time=2925.500..2925.500 rows=12358141 loops=3)
                                Index Cond: ("time" <= '2018-03-28 08:00:00'::timestamp without time zone)
                                Buffers: shared hit=67539 read=33770
Planning time: 0.444 ms
Execution time: 195672.969 ms

I don't have a clue on why this simple query is so slow, I only managed to speed it up a little bit by creating an index on order_history.time, but that's all. Any suggestion is welcome!


Solution

    • time is a bad name for a (timestamp!) column, avoid it
    • order is a bad name for a table, avoid it
    • there is an index missing for `close_time'
    • try to avoid NULLs in timestamp (almost key-field) columns, avoiding the `... OR xxx IS NULL
    • instead,you could use sane defaults, such as now() or +/-infinity
    • the final sort step could shipwreck your yuery plan.

    Also: you probably don't need the surrogate key id on order_history. The natural key (order_id,ztime) will suffice.


    \i tmp.sql
    
    CREATE TABLE orders (
        id uuid NOT NULL
        , side varchar(4) NOT NULL
        , product varchar(7) NOT NULL
        , price numeric(18,8) NOT NULL
        , close_time timestamp NOT  NULL DEFAULT ('infinity'::timestamp)
        , CONSTRAINT order_pkey PRIMARY KEY (id)
    );
    CREATE TABLE order_history (
        id serial NOT NULL
        , amount numeric(18,8) NOT NULL
        , ztime timestamp NOT NULL  DEFAULT ('-infinity'::timestamp)
        , order_id uuid NOT NULL
        , CONSTRAINT order_history_pkey PRIMARY KEY (id)
        , CONSTRAINT order_history_order_id_fkey FOREIGN KEY (order_id) REFERENCES orders(id)
    );
    
    -- CREATE INDEX order_history_order_id ON order_history USING btree (order_id);
    -- CREATE INDEX order_history_time_idx ON order_history USING btree (ztime);
    CREATE INDEX order_history_order_id_ztime ON order_history USING btree (order_id,ztime);
    CREATE INDEX order_h_ztime ON orders USING btree (close_time);
    
    EXPLAIN
    select
        oo.id
        , oo.side
        , oo.price
        , oo.close_time
        , oh.ztime
        , oh.amount
    from
        orders as oo
    inner join order_history as oh on oh.order_id = oo.id
    where oh.ztime <= '2018-03-28 08:00:00'
        and (oo.close_time > '2018-03-28 07:00:00' ) -- or oo.close_time is null)
        and oo.product = 'BTC-USD'
    order by oh.ztime
            ;
    

    Resulting plan (without any data!!!):


                                                           QUERY PLAN                                                       
    ------------------------------------------------------------------------------------------------------------------------
     Sort  (cost=16.98..16.99 rows=1 width=92)
       Sort Key: oh.ztime
       ->  Nested Loop  (cost=3.14..16.98 rows=1 width=92)
             ->  Bitmap Heap Scan on orders oo  (cost=1.94..13.64 rows=1 width=64)
                   Recheck Cond: (close_time > '2018-03-28 07:00:00'::timestamp without time zone)
                   Filter: ((product)::text = 'BTC-USD'::text)
                   ->  Bitmap Index Scan on order_h_ztime  (cost=0.00..1.94 rows=213 width=0)
                         Index Cond: (close_time > '2018-03-28 07:00:00'::timestamp without time zone)
             ->  Bitmap Heap Scan on order_history oh  (cost=1.20..3.33 rows=2 width=44)
                   Recheck Cond: ((order_id = oo.id) AND (ztime <= '2018-03-28 08:00:00'::timestamp without time zone))
                   ->  Bitmap Index Scan on order_history_order_id_ztime  (cost=0.00..1.20 rows=2 width=0)
                         Index Cond: ((order_id = oo.id) AND (ztime <= '2018-03-28 08:00:00'::timestamp without time zone))
    (12 rows)