Search code examples
javascriptreactjsfunctional-programmingfunctional-testing

Review my code Funcational Programing in React


I try to learn to write functional programming code in react. could you check and review my code and say to me is it functional or not? or how can I write it better!

Thank you very much

    oprationButton(val , oprator){ 

        if(oprator === 'min')
            return this.setState({currentVal: min(val)})
        else if(oprator === 'plus')
            return this.setState({currentVal: plus(val)})

        function min(val){ 
           if (val > 0)
            return val
            else return 0
        }

        function plus(val){
            return val + 1
        }      

}



    <button type="button" 
onClick={() => this.oprationButton(this.state.currentVal,'min')}>Click Me!</button>

Solution

  • you can change your code like this

    pluseButton(val, oprator) {
        if (oprator === 'min') {
            let min = this.mines(val)
            return this.setState({currentVal: min})
        } else if (oprator === 'plus')
            return this.setState({currentVal: ++val})
    }
    
    mines(val) {
        let sum = val - 1;
        if (sum > 0) return sum
        else return 0
    }
    
    
    
    
     <button type="button" 
    onClick={() => this.oprationButton(this.state.currentVal,'min')}>Click Me!</button>
    

    I hope this code help u