ArrayIndexOutOfBoundsException When Creating Deck of Cards in Java

Question

I am hoping to get some help even though I know this is probably a very simple bug that I cannot seem to find an answer to. What I am trying to accomplish is to create a deck of cards, and I keep running into an out of bounds error. Here is my code:

Card Class:

public class Card {
    private String suit;
    private int face;

    public Card(int face, String suit){
        face = this.face;
        suit = this.suit;
    }

    public int getFace(){
        return face;
    }

    public String getFaceAsString(int face){
        int faceName = face;
        String faceString = "";
        if(faceName == 11){
            faceString = "J";
        } else if(faceName == 12){
            faceString = "Q";
        } else if(faceName == 13){
            faceString = "K";
        } else if(faceName == 14){
            faceString = "A";
        } else {
            faceString = Integer.toString(faceName);
        }

        return faceString;

    }

    public String getSuit(){
        return suit;
    }

    public void setSuit(String suit){
        this.suit = suit;
    }

 }

This is my main class:

import java.util.Random;
import java.util.Scanner;

public class Hero_Game {

    public static void main(String[] args) {


        String[] suits = {"Spades","Clubs","Hearts","Diamonds"};
        int[] faces = {2,3,4,5,6,7,8,9,10,11,12,13,14,15};
        int index = 0;

        Card[] deck = new Card[52];

        for(int i = 0; i<suits.length;i++){
            for(int j = 0; j<faces.length;j++){
               deck[index] = new Card(faces[i],suits[j]);
               index++;
            }
        }

Answer 1

You switched the indexes for the faces and suits arrays in your for loops. It should be:

for(int i = 0; i<suits.length;i++){
    for(int j = 0; j<faces.length;j++){
        deck[index] = new Card(faces[j],suits[i]);
        index++;
    }
}