Search code examples
angularjsangularjs-material

Is it good to fix issues in library files and use them in our project

I encountered an issue in angular-material.js Version 1.1.9, I was able to fix the issue in the library file. Is it okay to use my fix in my project without checking in my fix in AngularJS Material's GitHub repository.

Solution

  • It would certainly be a better approach to file a Pull Request with the library project. Why?

    • It will make you a better human being with glowing, wonderfully clear skin: You already have a bugfix, so why not share it?
    • If you don't get it into the library, with the next update, you will lose your bugfix and will end up monkey-patching it with every new release.