Search code examples
vbscriptftpfilesystemwatcher

TextStream.AtEndOfStream sometimes is never true

I have a vb script that processes text files on a server, however, very occasionally without any apparent reason, the script gets stuck in a loop.

Files are uploaded by clients via ftp (smallish about 2 - 10 kb), a .Net service that is watching the ftp folder kicks off an executable (written in VB6), the executable moves the file from the ftp folder to a folder where it is processed. At this point the exe kicks off the vb script. 98% of the time the script runs without issue.

When the infinite loop occurs I kill the exe process. The odd thing is that when I re-kick off the process manually (by copying it back to the the folder that's being watched) the exact same file it goes through without issue.

In short the script opens the file into a text stream then it loops through the TextStream object until its AtEndOfStream property is true. Within the loop it creates a new file with some additional information added, now whenever the infinate loop situation occurs the temp file doesnt contain any of the sourcefile data, just the extra data added by the script, for example, the following code works 98% of the time:

Do While ts.AtEndOfStream <> True
    sOriginalRow = ts.ReadLine
    sUpdatedRow = sOriginalRow & ",Extra_Data"
    NewFile.WriteLine sUpdatedRow
Loop

So if the source file contains:

LineA
LineB
LineC

The new file is created conbtaining:

LineA,Extra_Data
LineB,Extra_Data
LineC,Extra_Data

but when the problem occurs and the new file is instantly populated with thousands of rows of

,Extra_Data
,Extra_Data
,Extra_Data
,Extra_Data
,Extra_Data
...

its as though the AtEndOfStream property never becomes true.

My initial thought is that the source file is getting corrupted somehow but when these source files are reprocessed they are fine. Another thought is that the textstream object is getting incorrectly created, and not picking up the new line character, maybe because the file is locked by another process or something.

The only way I have found to replicate the behaviour is to comment out the ReadLine part of the code, which in effect prevents the current line number from incrementing. e.g.

sOriginalRow = "" 'ts.ReadLine

Can anyone offer any suggestions?

Solution

  • Well, as you say, the only thing I can offer are suggestions, not real answers:

    Maybe your stream bumps against an ObjectDisposedException (not catchable in VBScript), so the EndOfStream condition gets <> True but not False.

    For the sake of the experiment, you could try to change Do While ts.AtEndOfStream <> True to Do While Not ts.AtEndOfStream or Do Until ts.AtEndOfStream but my bio-logical circuits tell me that is probably not going to work.

    There is another problem described where the stdIn and stdErr are conflicting with each other causing a hang in particular situations.

    Could you also please answer the comment of Tmdean. On Error Resume Next could create a real mess: If ts.AtEndOfStream returns Null or garbage (because ts was destroyed for example) it will not become True and will cause a loop in Foreverland.