Search code examples
gitbitbucketgit-branchgit-commitpull-request

Is it okay to update the Pull Request with commits before code is reviewed and commented on?


I have created a pull request of my branch after work is done, and have assigned it to code reviewers. After that I opened the pull request and observed my changes. Before anyone could review, I found 1 or 2 simple mistakes. I have corrected them on my local. If I commit and push them, the pull request will get updated.

Is it professionally correct to update pull request before it is reviewed and commented on by the code reviewers?

Thanks in advance.


Solution

  • I see nothing wrong with you updating your pull request if you think it requires that. I do this all the time, and in general I think both you and your reviewers will benefit from this. You benefit because it means both parties will spend less time later on dealing with these mistakes. And were you to not fix the mistakes now, you will just have to do it later.