Search code examples
gitgit-submodules

Git diff says subproject is dirty

I have just run a git diff, and I am getting the following output for all of my approx 10 submodules 

diff --git a/.vim/bundle/bufexplorer b/.vim/bundle/bufexplorer
--- a/.vim/bundle/bufexplorer
+++ b/.vim/bundle/bufexplorer
@@ -1 +1 @@
-Subproject commit 8c75e65b647238febd0257658b150f717a136359
+Subproject commit 8c75e65b647238febd0257658b150f717a136359-dirty

What does this mean? How do I fix it?

Solution

  • Update Jan. 2021, ten years later:

    "git diff"(man) showed a submodule working tree with untracked cruft as Submodule commit <objectname>-dirty, but a natural expectation is that the "-dirty" indicator would align with "git describe --dirty"(man), which does not consider having untracked files in the working tree as source of dirtiness.
    The inconsistency has been fixed with Git 2.31 (Q1 2021).

    See commit 8ef9312 (10 Nov 2020) by Sangeeta Jain (sangu09).
    (Merged by Junio C Hamano -- gitster -- in commit 0806279, 25 Jan 2021)

    diff: do not show submodule with untracked files as "-dirty"

    Signed-off-by: Sangeeta Jain

    Git diff reports a submodule directory as -dirty even when there are only untracked files in the submodule directory.
    This is inconsistent with what git describe --dirty(man) says when run in the submodule directory in that state.

    Make --ignore-submodules=untracked the default for git diff(man) when there is no configuration variable or command line option, so that the command would not give '-dirty' suffix to a submodule whose working tree has untracked files, to make it consistent with git describe --dirty that is run in the submodule working tree.

    And also make --ignore-submodules=none the default for git status(man) so that the user doesn't end up deleting a submodule that has uncommitted (untracked) files.

    git config now includes in its man page:

    By default this is set to untracked so that any untracked submodules are ignored.

    Original answer (2011)

    As mentioned in Mark Longair's blog post Git Submodules Explained,

    Versions 1.7.0 and later of git contain an annoying change in the behavior of git submodule.
    Submodules are now regarded as dirty if they have any modified files or untracked files, whereas previously it would only be the case if HEAD in the submodule pointed to the wrong commit.

    The meaning of the plus sign (+) in the output of git submodule has changed, and the first time that you come across this it takes a little while to figure out what’s going wrong, for example by looking through changelogs or using git bisect on git.git to find the change. It would have been much kinder to users to introduce a different symbol for “at the specified version, but dirty”.

    You can fix it by:

    • either committing or undoing the changes/evolutions within each of your submodules, before going back to the parent repo (where the diff shouldn't report "dirty" files anymore). To undo all changes to your submodule just cd into the root directory of your submodule and do git checkout .

    dotnetCarpenter comments that you can do a: git submodule foreach --recursive git checkout .

    • or add --ignore-submodules to your git diff, to temporarily ignore those "dirty" submodules.

    New in Git version 1.7.2

    As Noam comments below, this question mentions that, since git version 1.7.2, you can ignore the dirty submodules with:

    git status --ignore-submodules=dirty