Search code examples
androidandroid-fragmentsbottomnavigationviewandroid-bottomnavandroid-bottom-nav-view

BottomNavigation initial setCurrentItem not showing fragment and relaunching fragment fails


I have a Main Activity which uses a TabSelectedListener to show fragments for the AHBottomNavigation menu. The fragment called "FirstFragment" contains a FragmentPagerAdapter which allows the user to swipe between two tabs, each of which have its own fragment, called FirstTabInFirstFragmentFragment and SecondTabInFirstFragmentFragment (renamed for simplicity).

My issue is that:

a). When the Main Activity is launched, the "First" Bottom Navigation menu item is selected, however the "FirstFragment" is not launched. So, it shows the proper item selected with a blank screen. It only launches the First Fragment if I tap on the menu item again.

b). Once the FirstFragment has been properly launched and is being shown on screen (by the temporary fix done in a), if I select a different menu item (i.e. to navigate to SecondFragment) and then select the FirstFragment's menu item again, the two tabs within it are blank. Also, the sliding between the fragments for the two tabs does not work and gets "stuck" so you have to pull it all the way to one side or all the way to the other.

Hopefully I have explained my problem clearly - if there is anything I'm missing, I can provide more details.
Note that I am using com.aurelhubert.ahbottomnavigation.AHBottomNavigation
Here are the relevant files:

MainActivity.java:

public class MainActivity extends AppCompatActivity{

private AHBottomNavigationAdapter navigationAdapter;
private AHBottomNavigationViewPager viewPager;
private AHBottomNavigation bottomNavigation;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    // Add menu items to bar
    bottomNavigation = (AHBottomNavigation) findViewById(R.id.bottom_navigation);
    this.createNavItems();

    bottomNavigation.setOnTabSelectedListener(new AHBottomNavigation.OnTabSelectedListener() {
        @Override
        public boolean onTabSelected(int position, boolean wasSelected) {

            //show fragment
            if (position==0)
            {
                FirstFragment firstFragment=new FirstFragment();
                getSupportFragmentManager().beginTransaction().replace(R.id.content_id,firstFragment).commit();
            }else  if (position==1)
            {
                SecondFragment secondFragment=new SecondFragment();
                getSupportFragmentManager().beginTransaction().replace(R.id.content_id, secondFragment).commit();
            }else  if (position==2)
            {
                ThirdFragment thirdFragment=new ThirdFragment();
                getSupportFragmentManager().beginTransaction().replace(R.id.content_id,thirdFragment).commit();
            }else{
                FourthFragment fourthFragment=new FourthFragment();
                getSupportFragmentManager().beginTransaction().replace(R.id.content_id,fourthFragment).commit();
            }

            return true;
        }
    });
}

private void createNavItems(){
    navigationAdapter = new AHBottomNavigationAdapter(this, R.menu.navigation);
    navigationAdapter.setupWithBottomNavigation(bottomNavigation);

    // set current item
    bottomNavigation.setCurrentItem(0);
}

activity_main.xml

<?xml version="1.0" encoding="utf-8"?>
<android.support.design.widget.CoordinatorLayout
    xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    android:id="@+id/content_id"
    android:layout_width="match_parent"
    android:layout_height="match_parent">


    <com.aurelhubert.ahbottomnavigation.AHBottomNavigation
        android:id="@+id/bottom_navigation"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_gravity="bottom"/>

</android.support.design.widget.CoordinatorLayout>

FirstFragment.java:

public class FirstFragment extends Fragment {

    private FragmentActivity mContext;

    public FirstFragment() {
        // Required empty public constructor
    }

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {
        // Inflate the layout for this fragment
        return inflater.inflate(R.layout.fragment_first, container, false);

    }

    @Override
    public void onActivityCreated(@Nullable Bundle savedInstanceState){
        super.onActivityCreated(savedInstanceState);    

        // Set the content of the activity to use the activity_main.xml layout file
        //setContentView(R.layout.activity_first);

        // Find the view pager that will allow the user to swipe between fragments
        ViewPager viewPager = (ViewPager) getView().findViewById(R.id.viewpager);

        // Create an adapter that knows which fragment should be shown on each page
        // using getFragmentManager() will work too
        FirstFragmentPagerAdapter adapter = new FirstFragmentPagerAdapter(mContext.getSupportFragmentManager(), mContext);

        // Set the adapter onto the view pager
        viewPager.setAdapter(adapter);

        TabLayout tabLayout = (TabLayout) getView().findViewById(R.id.sliding_tabs);
        tabLayout.setupWithViewPager(viewPager);
    }

    /**
     * Override to set context.  This context is used for getSupportFragmentManager in onCreateView
     * @param activity
     */
    @Override
    public void onAttach(Activity activity) {
        mContext=(FragmentActivity) activity;
        super.onAttach(activity);
    }

}

fragment_first.xml:

<?xml version="1.0" encoding="utf-8"?>
<android.support.constraint.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    >

    <LinearLayout
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:orientation="vertical">

        <android.support.design.widget.TabLayout
            android:id="@+id/sliding_tabs"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            app:tabMode="fixed"
            app:tabBackground="@color/firstTabBackground"
            app:tabIndicatorColor="@color/firstTabIndicatorColor"/>

        <android.support.v4.view.ViewPager
            android:id="@+id/viewpager"
            android:layout_width="match_parent"
            android:layout_height="0px"
            android:layout_weight="1"/>

    </LinearLayout>


</android.support.constraint.ConstraintLayout>

FirstFragmentPagerAdapter.java:

public class FirstFragmentPagerAdapter extends FragmentPagerAdapter {

    private Context context;

    public FirstFragmentPagerAdapter(FragmentManager fm, Context mContext){
        super(fm);
        context = mContext;
    }


    /**
     * The ViewPager asks the adapter for the fragment at a given position,
     * i.e. for the 1st fragment, the ViewPager asks for the fragment at
     * position 1.
     * @param position
     * @return
     */
    @Override
    public Fragment getItem(int position){
        if (position == 0){
            return new FirstTabInFirstFragmentFragment();
        }
        else{
            return new SecondTabInFirstFragmentFragment();
        }
    }

    /**
     * On launch, the ViewPager asks the adapter how many pages there will be.
     * Here, our adapter returns how many pages there will be.
     * @return
     */
    @Override
    public int getCount() {return 2;}

    @Override
    public CharSequence getPageTitle(int position) {

        switch(position){
            case 0:
                return context.getResources().getString(R.string.first_tab_in_first_fragment_page_title);
            case 1:
                return context.getResources().getString(R.string.second_tab_in_first_fragment_page_title);
            default:
                return null;
        }
    }
}

Solution

  • I was able to solve this in two steps. First, in my Main Activiy method createNavItems, in addition to doing a bottomNavigation.setCurrentItem(0);, I also had to manually update the CoordinatorLayout (which has ID content_id) with the default fragment:

    getSupportFragmentManager().beginTransaction().replace(R.id.content_id, new FirstFragment()).commit();
    

    Next, to solve the TabLayout issues I had to change this line:

    FirstFragmentPagerAdapter adapter = new FirstFragmentPagerAdapter(mContext.getSupportFragmentManager(), mContext);
    

    to

    FirstFragmentPagerAdapter adapter = new FirstFragmentPagerAdapter(getChildFragmentManager(), mContext);
    

    The reason for this is that when nesting Fragments inside of other Fragments with ViewPager, getFragmentManager() is for managing Fragments within a Fragment whereas mContext.getSupportFragmentManager() is used for Activities.