Search code examples
objective-ccocoastringobject-comparison

Why is my comparing if statement not working?


Why is the following code (in cocoa) not working?

NSString *extension = [fileName pathExtension];
NSString *wantedExtension = @"mp3";
if(extension == wantedExtension){
//work
}

in Xcode this just runs without warnings or errors but doesn't do what I think it SHOULD do.


Solution

  • Shouldn't that be

    if ([extension isEqualToString:wantedExtension]) {
    ...
    }
    

    "==" compares the pointers. isEqual: and isEqualToString: compare the strings, although isEqualToString is better if you know both extension and wantedExtension are NSString (which you do in this case).

    Actually, if you're an old C++ and Java programmer like me, you might be happier putting the one that is known not to be null, "wantedextension", first. In Objective C that is not necessary because "sending a message" (ie calling a method) to a nil returns 0 or false.

    if ([wantedExtension isEqualToString:extension]) {
       ...
    }