Search code examples
windowswindows-installerinstallationinstallshield

Custom Action failing to execute during installation created with Installshield 16

I have run this custom action with Installshield Limited Edition for Visual Studio in the past and it has worked. But now when I try this with Installshield 2016, this custom action gives me a 1722 error and rolls back the installation. The log file doesn't give any more detail than "failed with error 1..." and the 1722 error.

My custom action setup via the Wizard -

Working Dir: InstallDir

FileName & Command Line: "[SystemFolder]cmd.exe" /c "[INSTALLDIR]somefilename.exe" "'%r' '%keyname=keyname' '%keydll=some.dll' '%appexe=[INSTALLDIR]differentfilename.exe'"

What this is supposed to do is run somefilename.exe from the command line, with parameters "%r", "%keyname", "%keydll" & "%appexe".

When I run it on the command line directly so - "C:\Program Files (x86)"\somefilename.exe "%r" "%keyname=keyname" "%keydll=some.dll" "%appexe=C:\Program Files (x86)\differentfilename.exe" - it runs fine.

I think I am missing some quotes someplace and I have tried various combinations with no luck.

Any ideas what I am doing wrong?

Thanks in advance!

Solution

  • Thanks for the suggestions @PhilDW.

    I could possibly take out the cmd jacket and just run the exe and try.

    I finally got it working though, by changing some quotes etc. Here's what the final FileName & Command Line argument looks like:

    "[SystemFolder]cmd.exe" /c start "" /d"C:\Program Files (x86)\foldername\" "somefile.exe" "%r" "%keyname=something" "%keydll=something.dll" "%appexe=C:\Program Files (x86)\otherfilename.exe"

    Hope this helps someone.