Search code examples
javascriptscreeps

Screeps: Get the id of an object


I tried to write a code that prevents 2 creeps (harvester) from going to the same destination and binds them to that destination until its full.

on line 55 I get an error which is understandable

55: creep.memory.targetID = targets[checkTarget].id; for a reason that I am not seeing targets[checkTarget] is null

Can anyone tell me what i am doing wrong?

var roleHarvester = {

    /** @param {Creep} creep **/
    run: function(creep) {
        if (!creep.memory.targetID) creep.memory.targetID = "not given";
        console.log(creep.memory.targetID);
        if (creep.carry.energy < creep.carryCapacity) {
            var nearestSource = creep.pos.findClosestByPath(FIND_SOURCES_ACTIVE);
            if (creep.harvest(nearestSource) == ERR_NOT_IN_RANGE) {
                creep.moveTo(nearestSource, {
                    visualizePathStyle: {
                        stroke: '#ffaa00'
                    }
                });
            }
        } else {
            if (creep.memory.targetID != "not given") {
                console.log("should not be not given");
                if (Game.getObjectById(creep.memory.targetID).hits == Game.getObjectById(creep.memory.targetID).hitsMax) {
                    creep.memory.targetID = "not given";

                    var targets = creep.room.find(FIND_STRUCTURES, {
                        filter: (structure) => {
                            return (structure.structureType == STRUCTURE_SPAWN ||
                                structure.structureType == STRUCTURE_EXTENSION ||
                                structure.structureType == STRUCTURE_TOWER) && structure.energy < structure.energyCapacity;
                        }
                    });
                } else {
                    if (creep.transfer(Game.getObjectById(creep.memory.targetID), RESOURCE_ENERGY) == ERR_NOT_IN_RANGE) {
                        creep.moveTo(Game.getObjectById(creep.memory.targetID), {
                            visualizePathStyle: {
                                stroke: '#ffffff'
                            }
                        });
                    }
                }
            } else {
                var targets = creep.room.find(FIND_STRUCTURES, {
                    filter: (structure) => {
                        return (structure.structureType == STRUCTURE_SPAWN ||
                            structure.structureType == STRUCTURE_EXTENSION ||
                            structure.structureType == STRUCTURE_TOWER) && structure.energy < structure.energyCapacity;
                    }
                });
                console.log(targets);
                for (var checkTarget in targets) {
                    console.log(checkTarget);
                    console.log(targets[checkTarget]);
                    for (var name in Game.creeps) {
                        if (targets[checkTarget] = Game.getObjectById(Game.creeps[name].memory.targetID)) {
                            var fail = true;
                            break;
                        }
                        var fail = false;
                    }
                    if (fail == true) continue;

                    console.log(Game.getObjectById(targets[checkTarget]));
                    creep.memory.targetID = targets[checkTarget].id;
                    break;

                }
            }
        }
    }
};

module.exports = roleHarvester;

Solution

  • Something wrong in the following if condition:

    for(var name in Game.creeps) {
       if(targets[checkTarget] = Game.getObjectById(Game.creeps[name].memory.targetID)){
    

    Probably you mean == ?