Search code examples
umldiagramsoftware-designclass-diagram

UML( Domain Class Diagram) is my Domain Class Diagram correct?

Currently I am dealing with UMl diagrams of the SOS game that I am planning to create, But I am not sure if my domain class diagram is correct. Can please someone tell me that if I have aany problem with my domain class diagram? Thanks.

interface sketch 1

interface sketch 2

interface sketch 3

enter image description here

Solution

  • as @ThomasKilian said in the comments, It is hard to correct this model without proper domain documents.

    I offer some hints just by my knowledge from your pictures, You have some mistakes and some bad designs:

    1. Human Player 1 and Human Player 2 are not Classes. They are instances of one class can be named : Human Class that be inherited from Player.

    2. Score can be an attribute of Player, not a class. If it should be class, a relationship needs between Score and Player.

    3. Your Menu class can be decompose to it's sub classes.

    4. 7*7 Grid class can be changed to Grid class with the rows and columns attribute.

    5. After Frame class, you can use a class named Cell, then Filled with S Class, Filled with O and Empty Class can be Inherited from Cell (Not Frame)

    6. In professional view, You SOS Game class is a GOD Class. (See this book: Object Oriented Design Heuristics, Arthur J. Riel, 1996, to handle it)