Search code examples
javaexceptionstackinfix-notation

Empty Stack Exception in Infix Expression Solver


So my program is suppose to take an syntactically correct infix expressions that contain integer operands and the four arithmetic operators (+ - * /) from a GUI and display the results. Unfortunately, if I input a simple expression like 3 + 4, the program throws a empty stack exception. I've only just started working with stacks so forgive me if its something simple that im getting wrong. Please help!

import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
import java.util.*;


public class inFix extends JFrame
{
   private Container contents;
   private JLabel infixLabel, resultLabel, result;
   private JTextField infixText;
   private JButton evaluate;

   public inFix()
   {
      super("Infix Expresion Evaluator");
      contents = getContentPane();
      contents.setLayout( new FlowLayout() );

      infixLabel = new JLabel("Enter Infix Expression:");
      infixText = new JTextField("", 14);

      evaluate = new JButton("Evaluate");

      resultLabel = new JLabel("Result:");
      result = new JLabel("???");

      contents.add( infixLabel );
      contents.add( infixText );
      contents.add( evaluate );
      contents.add( resultLabel );
      contents.add( result );


      ButtonHandler bh = new ButtonHandler();

      evaluate.addActionListener( bh );

      setSize( 350, 200 );
      setVisible( true );
   }

   private class ButtonHandler implements ActionListener
   {
      public void actionPerformed( ActionEvent ae )
      {
         result.setText(infix(infixText.getText()));
      }
   }


   public String infix(String expression)
   {
      expression=expression.replaceAll("[\t\n ]", "")+"=";
      String operator = "*/+-";
      int value1, value2;
      char ch;
      StringTokenizer tokenizer = new StringTokenizer(expression, operator, true); 
      Stack<Integer> valueStack = new Stack<Integer>();
      Stack<Character> operatorStack = new Stack<Character>();

      while(tokenizer.hasMoreTokens())
      {
         String token = tokenizer.nextToken();
         if(isInteger(token) == true)
            valueStack.push(Integer.parseInt(token));
         else if(token.charAt(0) == '(')
            operatorStack.push(token.charAt(0));
         else if(token.charAt(0) == ')')
            while(operatorStack.peek() != '(')
            {
               value1 = valueStack.pop();
               value2 = valueStack.pop();
               valueStack.push(solver(value1, value2, operatorStack.pop()));
            }
         else if(token.charAt(0) == '+' || token.charAt(0) == '-' || token.charAt(0) == '*' || token.charAt(0) == '/')
         {
            while(!operatorStack.isEmpty() && precedence(token.charAt(0)) <= precedence(operatorStack.peek()))
            {
               value1 = valueStack.pop();
               value2 = valueStack.pop();
               valueStack.push(solver(value1, value2, token.charAt(0)));
            }
            operatorStack.push(token.charAt(0));
         }
      }
      while(!operatorStack.isEmpty())
      {
         value1 = valueStack.pop();
         value2 = valueStack.pop();
         ch = operatorStack.pop();
         valueStack.push(solver(value1, value2, ch));
      }


      String result = Integer.toString(valueStack.pop());
      return result;     
   }

   public static boolean isInteger(String s)
   {
      try
      { 
         Integer.parseInt(s);
      } 
      catch(NumberFormatException e)
      {
         return false; 
      } 
      catch(NullPointerException e) 
      {
         return false;
      }
      return true;
   }
   public int solver( int value1, int value2, char operator)
   {
      if(operator == '*')
         return value1 * value2;
      else if(operator == '/')
         return value1 / value2;
      else if(operator == '+')
         return value1 + value2;
      else if(operator == '-')
         return value1 - value2;
      else
         return 0;
   }

   public int precedence(char op)
   {
      if(op == '+' || op == '-')
         return 1;
      else if(op == '*' || op == '/')
         return 2;
      else
         return -1;
   }   


   public static void main( String [] args )
   {
      inFix infixsolver = new inFix();
      infixsolver.setDefaultCloseOperation( JFrame.EXIT_ON_CLOSE );
   }

}

Solution

  • Suppose the input expression is "3+4" On line 54

    expression=expression.replaceAll("[\t\n ]", "")+"=";
    

    the expression become "3+4=" After the tokenizer operation, the tokens are ["3","+","4="], which produce a false result for token "4=" on line 65

    if(isInteger(token) == true)
    

    hence the number of value is not enough when you pop on line 89

         value2 = valueStack.pop();
    

    to solve the problem, remove the +"=" in line 54

    expression=expression.replaceAll("[\t\n ]", "")+"=";