Search code examples
phpobjectkeyvaluepair

cant set php key-value pair set properly


I have a key value pair that I am using inside of a class, but it is not returning the data the way I want it. I want the value in GB&Lv to be in the key area and the value to be in the value area. However my debug output seems to indicate that I am currently placing the value in the key section of the key value pair?

class Player{
    var $PlayerName ;
    var $TotalContributedPoints;
    function GetTotalContributedPoints()
    {
            $mysqli = new mysqli("localhost", "user", "password", "foe_gb_contribs_test");
        if ($mysqli->connect_errno) {
           echo "Failed to connect to MySQL: (" . $mysqli->connect_errno . ") " . $mysqli->connect_error;
        }

        $debug = true;

        if ($debug == true) {echo $this->PlayerName.'<br>';}
        $QuerySQL = "SELECT * FROM `GB_Contribs` WHERE Player_Nick = '".$this->PlayerName."' order by DATE ASC";
        if ($debug == true) {echo 'Query is '.$QuerySQL.'<br>';}
        $ContribArray = array("Key" => "Value");
        $result = $mysqli->query($QuerySQL);
        if ($result->num_rows > 0) {
            while($row=$result->fetch_assoc()) {
                $ContribArray[$row['GB&Lv']] = $row['Value'];
            }
            foreach($ContribArray as $key => $value) {
                echo "Player_nick: ". $this->PlayerName ."<br>";
                echo "Great Building Level: ".$ContribArray[$key]."<br>";
                echo "Contribution Points".$ContribArray[$value]."<br>";
            }
            return $ContribArray;

        }  else {
            if ($debug == true) {echo "0 results";}
            return;
        }


    }

}// END of Player Class

Solution

  • As you're iterating the array with foreach, you already have the key and value. You don't need to refer to the array again.

    foreach($ContribArray as $key => $value) {
        echo "Player_nick: ". $this->PlayerName ."<br>";
        echo "Great Building Level: ".$key."<br>";         // not $ContribArray[$key]
        echo "Contribution Points".$value."<br>";          // not $ContribArray[$value]
    }
    

    As it is, $ContribArray[$key] gets you the value, and I would assume $ContribArray[$value] doesn't get you anything. In fact, it seems like it would probably cause an undefined index notice.