Push_back odd numbers

Question

So, the goal of the function is to add odd numbers to the array between 1 and a provided integer (inclusive). It seems like a simple task, however, I can't seem to get it to successfully add the integers to the actual array.

void populate(std::vector<int> ary, int a)
{
    for (int i = 1; i <= a; i++)
    {
        if (i % 2 != 0)
        {

            ary.push_back(i);
        }

    }
}

The function itself isn't const, so shouldn't it be adding values to the array successfully?

EDIT: This is all done in a main, so here it is.

int main()
{
    std::vector<int> loli(100);

    populate(loli, 31);


    for (int value : loli)
    {

        std::cout << value << " ";
        system("pause");
    }
}

EDIT 2: I've tried adding a return statement instead, however i still get the result zero.

std::vector<int> populate(std::vector<int> ary, int a)
{
    for (int i = 1; i <= a; i++)
    {
        if (i % 2 != 0)
        {

            ary.push_back(i);
        }

    }
    return ary;
}



int main()
{

    std::vector<int> loli(100);




    for (int value : populate(loli, 31))
    {

        std::cout << value << " ";
        system("pause");
    }



}

Answer 1

Your function should either return the final array after the for loop or you should pass the array as a pointer to the function.