Search code examples
sessionmojoliciousperl

Mojolicious session does not expire


I'm building a web application using mojolicious. The logout functionality works only while running the app on local machines. When I try to logout on the app running on the server, the session does not expire and I remain logged in.

This started to happen when we changed logout to be done via POST request instead of get.

The way we call logout is as an AJAX call from the frontend:

function do_logout() {
   $.post( "<%= url_for('on_logout') %>", function() {});
}

Logout route:

$if_login->post('/logout')->name('on_logout')->to('user#on_logout');

Logout controller:

sub on_logout {
  my $self = shift;
  $self->session(expires => 1);
  return $self->redirect_to('home');
}

Line which sets the session to expire is called, but after the redirect, session still contains the username which was logged in.


Solution

  • We finally found the error, the request was made using an

    <a href="" onclick="do_logout()"></a>
    

    which was basically doing 2 actions at once and creating a race condition. Here is the relevant code snippet

    # Relevant routes
    my $if_login = $r->under('/')->to('user#is_logged_in');
    $if_login->post('/logout')->name('on_logout')->to('user#on_logout');
    
    # Controller functions
    sub on_logout {
      my $self = shift;
      $self->session(expires => 1);
    
      return $self->render(json => '{success: "true"}');
    }
    
    sub is_logged_in {
      my $self = shift;
    
      say $self->session('username');  # Sometimes after on_logout this is still
                                       # defined and equal to the username.
      return 1 if($self->session('username'));
    
      $self->render(
        template => 'permission/not_logged_in',
        status => 403
      );
      return;
    }
    
    # Front end
    <a href="" onclick='do_logout();'>
     <%= l('Log out') %>
    </a>
    
    <script>
    function do_logout() {
      $.post( "<%= url_for('on_logout') %>", function() {
    }).fail(function() {
      alert( "error logging out" );
    }).done(function( data ) {
      alert( "Data: " + data );
    }).always(function() {
      alert( "finished" );
    });
    }
    </script>
    

    Thanks for helping!