How to unregister an NSNotification in Swift iOS

Question

I have two controllers

class CtrlA: UIViewController {
    override func viewWillAppear(_ animated: Bool) {
        super.viewWillAppear(animated)

        NotificationCenter.default.addObserver(CtrlB.self, selector: #selector(CtrlB.badge(notification:)), name: NSNotification.Name(rawValue: "badge"), object: nil)
    }

    override func viewWillDisappear(_ animated: Bool) {
        super.viewWillDisappear(animated)

        NotificationCenter.default.removeObserver(CtrlB.self, name: NSNotification.Name(rawValue: "badge"), object: nil)
    }
}

class CtrlB: UIViewController {
    static func badge (notification: NSNotification) {
        // blah blah
    }
}

Whats the correct way to unregister the notification listener above? I'm not certain this is correct: NotificationCenter.default.removeObserver(CtrlB.self, name: NSNotification.Name(rawValue: "badge"), object: nil)

I don't think I can use self either, since it was registered on CtrlB.self

Answer 1

So the best way to implement the notification in your project is create one class called NotificationManager inside that declare one dictionary in which you can always update the observers

class NotificationManager {
var observers = [String: AnyObject]()
}

Create addObserver method, post notification method and remove observer method inside the same class.

func postNotification(_ name: String, userInfo: [AnyHashable: Any]? = nil) {
    NotificationCenter.default.post(name: name, object: nil, userInfo: userInfo)
}

func addObserver(_ name: String, block: @escaping (Notification) -> Void) {
 //if observer is already in place for this name, remove it
  removeObserverForName(name)
  let observer = NotificationCenter.default.addObserver(forName: name), object: nil, queue: OperationQueue.main, using: block)
  self.observers[name] = observer
}

func removeObserver(_ name: name) {
 guard let observer = self.observers[name] else { return }
 NotificationCenter.default.removeObserver(observer)
 self.observers.removeValue(forKey: name)
}

 //Removes all observers
func removeAllObservers() {
for observer in self.observers.values {
 NotificationCenter.default.removeObserver(observer)
 }self.observers = [:]
}

So access the above method in any of your class wherever its required and it will take care of everything. This will also prevent crash in your code. If try to remove the same observer more than one time.