Search code examples
swiftuiviewcontrolleruistoryboardfacebook-loginuipageviewcontroller

Swift 3 - UIPageViewController - Presenting view controllers on detached view controllers is discouraged


Iam using UIPageViewController for my app's first open. And third page is my login page. This contains facebook login. When I clicked facebook login button, opening empty page and xcode give me this output "Presenting view controllers on detached view controllers is discouraged < tapusor.LoginPage: 0x101f09a00 >."

When I dont use UIPageViewController this button is working. So there is my code. How can I fix this issue?

import UIKit

class MyPageViewController: UIPageViewController, 
UIPageViewControllerDataSource, UIPageViewControllerDelegate {

var pageContainer: UIPageViewController!
// The pages it contains
var pages = [UIViewController]()

// Track the current index
var currentIndex: Int?
private var pendingIndex: Int?

override func viewDidLoad() {
    super.viewDidLoad()
    // Setup the pages
    let storyboard = UIStoryboard(name: "Main", bundle: nil)
    let page1: UIViewController! = storyboard.instantiateViewController(withIdentifier: "firstVC")
    let page2: UIViewController! = storyboard.instantiateViewController(withIdentifier: "secondVC")
    let page3: UIViewController! = storyboard.instantiateViewController(withIdentifier: "LoginPage")
    pages.append(page1)
    pages.append(page2)
    pages.append(page3)

    pageContainer = UIPageViewController(transitionStyle: .scroll, navigationOrientation: .horizontal, options: nil)
    pageContainer.delegate = self
    pageContainer.dataSource = self
    pageContainer.setViewControllers([page1], direction: UIPageViewControllerNavigationDirection.forward, animated: false, completion: nil)
    // Add it to the view
    view.addSubview(pageContainer.view)

}

func pageViewController(_ pageViewController: UIPageViewController, viewControllerBefore viewController: UIViewController) -> UIViewController? {

    let currentIndex = pages.index(of: viewController)!
    if currentIndex == 0 {
        return nil
    }
    let previousIndex = abs((currentIndex - 1) % pages.count)
    return pages[previousIndex]
}

func pageViewController(_ pageViewController: UIPageViewController, viewControllerAfter viewController: UIViewController) -> UIViewController? {

    let currentIndex = pages.index(of: viewController)!
    if currentIndex == pages.count-1 {
        return nil
    }
    let nextIndex = abs((currentIndex + 1) % pages.count)
    return pages[nextIndex]

}

func pageViewController(_ pageViewController: UIPageViewController, willTransitionTo pendingViewControllers: [UIViewController]) {
    pendingIndex = pages.index(of: pendingViewControllers.first!)
}

override func didReceiveMemoryWarning() {
    super.didReceiveMemoryWarning()
}

}

Also I can try this

let page3: UIViewController! = storyboard.instantiateViewController(withIdentifier: "LoginPage")

to this

let page3: UIViewController! = storyboard.instantiateViewController(withIdentifier: "LoginPage") as! LoginPage

or this

let page3: LoginPage! = storyboard.instantiateViewController(withIdentifier: "LoginPage") as! LoginPage

Not worked.


Solution

  • Create delegate for your LoginPage controller with function what will notify about Facebook login button pressed. Something like this:

    protocol LoginPageDelegate: class {
        func loginPageDidPressFacebookButton(_ controller: LoginPage)
    }
    

    Now add delegate property to your LoginPage class

    class LoginPage: UIViewController {
        weak var delegate: LoginPageDelegate?
    }
    

    Now you need to inform delegate when user press Facebook login button

    @IBAction func facebookButtonPressed(button: UIButton) {
        self.delegate?.loginPageDidPressFacebookButton(self)
    }
    

    And not you can subscribe to this delegate in your MyPageViewController.

    First you need to make it class conform to LoginPageDelegate

     class MyPageViewController: UIPageViewController,
    UIPageViewControllerDataSource, UIPageViewControllerDelegate, LoginPageDelegate {
    
        //MARK: LoginPageDelegate methods
    
        func loginPageDidPressFacebookButton(_ controller: LoginPage) {
            //present what you need here
        }
    }
    

    And now before you show you LoginPage:

    let page3: LoginPage! = storyboard.instantiateViewController(withIdentifier: "LoginPage")
        page3.delegate = self