Search code examples
javascriptnode.jstddmocha.jsenzyme

eslint should be listed in the project's dependencies, not devDependencies


Either I don't understand dependencies vs. devDependencies in node 100% yet or eslint is just wrong here (not capable of analyzing this correctly):

   3:1   error  'chai' should be listed in the project's dependencies, not devDependencies              import/no-extraneous-dependencies
   4:1   error  'chai-enzyme' should be listed in the project's dependencies, not devDependencies       import/no-extraneous-dependencies
   5:1   error  'enzyme' should be listed in the project's dependencies, not devDependencies            import/no-extraneous-dependencies
   7:1   error  'sinon' should be listed in the project's dependencies, not devDependencies             import/no-extraneous-dependencies
   9:1   error  'redux-mock-store' should be listed in the project's dependencies, not devDependencies  import/no-extraneous-dependencies

These are test dependencies, so why is it saying that they should be listed in dependencies?

Additional note: We're using Travis as our CI so I don't know if it makes a difference for that at all either.


Solution

  • Solved it with adding this to my .eslintrc:

    "import/no-extraneous-dependencies": ["error", {"devDependencies": true}]

    [no-extraneous-dependencies] Add exceptions? #422

    Based on this user's reply:

    you could set the option devDependencies: true in an .eslintrc in your test folder:

    rules: import/no-extraneous-dependencies: [error, { devDependencies: true }] Then you'll get reports of any packages referenced that are not included dependencies or devDependencies. Then you get the goodness of the rule, with no noise from the disable comments.

    I think that might work for you? This is how I would use the rule, in your case, since you have your test code separated into a test directory.

    Also this post was helpful to confirm I wasn't insane to not want some of these in my dependencies list: Sharable ESLint Config