Search code examples
javaspringrestasynchronousrest-client

Return Value from async rest template spring


I am creating a async rest call using spring

@GetMapping(path = "/testingAsync")
public String value() throws ExecutionException, InterruptedException, TimeoutException {
    AsyncRestTemplate restTemplate = new AsyncRestTemplate();
    String baseUrl = "https://api.github.com/users/XXX";
    HttpHeaders requestHeaders = new HttpHeaders();
    requestHeaders.setAccept(Arrays.asList(MediaType.APPLICATION_JSON));
    String value = "";

    HttpEntity entity = new HttpEntity("parameters", requestHeaders);
    ListenableFuture<ResponseEntity<User>> futureEntity = restTemplate.getForEntity(baseUrl, User.class);

    futureEntity.addCallback(new ListenableFutureCallback<ResponseEntity<User>>() {
        @Override
        public void onSuccess(ResponseEntity<User> result) {
            System.out.println(result.getBody().getName());
            // instead of this how can i return the value to the user ?
        }

        @Override
        public void onFailure(Throwable ex) {

        }
    });

    return "DONE"; // instead of done i want to return value to the user comming from the rest call 
}

And is there any way i can convert ListenableFuture to use CompletableFuture that is used in java 8 ?


Solution

  • There are basically 2 things you can do.

    1. Remove the ListenableFutureCallback and simply return the ListenableFuture
    2. Create a DeferredResult and set the value of that in a ListenableFutureCallback.

    Returning a ListenableFuture

    @GetMapping(path = "/testingAsync")
    public ListenableFuture<ResponseEntity<User>> value() throws ExecutionException, InterruptedException, TimeoutException {
        AsyncRestTemplate restTemplate = new AsyncRestTemplate();
        String baseUrl = "https://api.github.com/users/XXX";
        HttpHeaders requestHeaders = new HttpHeaders();
        requestHeaders.setAccept(Arrays.asList(MediaType.APPLICATION_JSON));
        String value = "";
    
        HttpEntity entity = new HttpEntity("parameters", requestHeaders);
        return restTemplate.getForEntity(baseUrl, User.class);
    }
    

    Spring MVC will add a ListenableFutureCallback itself to fill a DeferredResult and you will get a User eventually.

    Using a DeferredResult

    If you want more control on what to return you can use a DeferredResult and set the value yourself.

    @GetMapping(path = "/testingAsync")
    public DeferredResult<String> value() throws ExecutionException, InterruptedException, TimeoutException {
        AsyncRestTemplate restTemplate = new AsyncRestTemplate();
        String baseUrl = "https://api.github.com/users/XXX";
        HttpHeaders requestHeaders = new HttpHeaders();
        requestHeaders.setAccept(Arrays.asList(MediaType.APPLICATION_JSON));
        String value = "";
    
        HttpEntity entity = new HttpEntity("parameters", requestHeaders);
        final DeferredResult<String> result = new DeferredResult<>();
        ListenableFuture<ResponseEntity<User>> futureEntity = restTemplate.getForEntity(baseUrl, User.class);
    
        futureEntity.addCallback(new ListenableFutureCallback<ResponseEntity<User>>() {
            @Override
            public void onSuccess(ResponseEntity<User> result) {
                System.out.println(result.getBody().getName());
                result.setResult(result.getBody().getName());
            }
    
            @Override
            public void onFailure(Throwable ex) {
                result.setErrorResult(ex.getMessage());
            }
        });
    
        return result;
    }