javaswingpaint
Flickers too much
I wanted to write a simple car crashing game. But it flickers too much. I created 5 threads but i've given here just one. So, I had to use repaint() method much often. Now, I dont know to how to stop this flickering.
Thanks in advance :)
Frame
import java.awt.*;
import java.awt.event.*;
import java.util.Random;
import javax.swing.JFrame;
public class Frame extends JFrame implements KeyListener {
int bcx = Game.bx;
int bcy = Game.by;
int oc1x = Game.o1x;
int oc1y = Game.o1y;
int oc2x = Game.o2x;
int oc2y = Game.o2y;
int oc3x = Game.o3x;
int oc3y = Game.o3y;
int oc4x = Game.o4x;
int oc4y = Game.o4y;
int oc5x = Game.o5x;
int oc5y = Game.o5y;
Rectangle rbc, roc1, roc2, roc3, roc4, roc5, rs1, rs2, rs3;
Frame() {
super("Clash101");
setSize(1000, 1000);
setLayout(new FlowLayout());
// setFocusable(true);
addKeyListener(this);
setVisible(true);
setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
move();
Label l1 = new Label("Score");
l1.setBounds(50, 50, 50, 25);
add(l1);
}
public void paint(Graphics g) {
if ((Game.score % 5 == 0) && (Game.speed > 1) && (Game.stat == true)) {
Game.speed--;
Game.stat = false;
}
rbc = new Rectangle(bcx, bcy, 55, 105);
roc1 = new Rectangle(oc1x, oc1y, 55, 105);
roc2 = new Rectangle(oc2x, oc2y, 55, 105);
roc3 = new Rectangle(oc3x, oc3y, 55, 105);
roc4 = new Rectangle(oc4x, oc4y, 55, 105);
roc5 = new Rectangle(oc5x, oc5y, 55, 105);
rs1 = new Rectangle(275, 70, 451, 30);
rs2 = new Rectangle(245, 70, 30, 910);
rs3 = new Rectangle(726, 70, 30, 910);
if ((rbc.intersects(roc1) == true) || (rbc.intersects(roc2) == true) || (rbc.intersects(roc3) == true)
|| (rbc.intersects(roc4) == true) || (rbc.intersects(roc5) == true) || (rbc.intersects(rs1) == true)
|| (rbc.intersects(rs2) == true) || (rbc.intersects(rs3) == true)) {
System.out.println("Collision");
System.out.println("Score: " + Game.score);
System.out.println("Speed: " + Game.speed);
System.exit(0);
}
g.setColor(Color.WHITE);
g.fillRect(0, 0, 1000, 1000);
g.setColor(Color.BLACK);
g.drawRect(275, 100, 450, 850);
g.drawRect(365, 100, 90, 850);
g.drawRect(545, 100, 90, 850);
Toolkit t = Toolkit.getDefaultToolkit();
Image blueCar = t.getImage("blue_car.png");
Image orangeCar = t.getImage("orange_car.png");
if ((Game.rn1 == 1) || (Game.rn2 == 1) || (Game.rn3 == 1) || (Game.rn4 == 1) || (Game.rn5 == 1)) {
g.drawImage(orangeCar, oc1x, oc1y, this);
}
if ((Game.rn1 == 2) || (Game.rn2 == 2) || (Game.rn3 == 2) || (Game.rn4 == 2) || (Game.rn5 == 2)) {
g.drawImage(orangeCar, oc2x, oc2y, this);
}
if ((Game.rn1 == 3) || (Game.rn2 == 3) || (Game.rn3 == 3) || (Game.rn4 == 3) || (Game.rn5 == 3)) {
g.drawImage(orangeCar, oc3x, oc3y, this);
}
if ((Game.rn1 == 4) || (Game.rn2 == 4) || (Game.rn3 == 4) || (Game.rn4 == 4) || (Game.rn5 == 4)) {
g.drawImage(orangeCar, oc4x, oc4y, this);
}
if ((Game.rn1 == 5) || (Game.rn2 == 5) || (Game.rn3 == 5) || (Game.rn4 == 5) || (Game.rn5 == 5)) {
g.drawImage(orangeCar, oc5x, oc5y, this);
}
g.drawImage(blueCar, bcx, bcy, this);
g.setColor(Color.BLACK);
g.fillRect(275, 70, 451, 30);
g.fillRect(275, 950, 451, 30);
g.fillRect(245, 70, 30, 910);
g.fillRect(726, 70, 30, 910);
g.setColor(Color.WHITE);
g.fillRect(275, 980, 451, 100);
g.fillRect(275, 0, 451, 69);
}
public void keyPressed(KeyEvent ke) {
int key = ke.getKeyCode();
if (key == KeyEvent.VK_LEFT) {
bcx = bcx - 10;
}
if (key == KeyEvent.VK_RIGHT) {
bcx = bcx + 10;
}
if (key == KeyEvent.VK_UP) {
bcy = bcy - 10;
}
if (key == KeyEvent.VK_DOWN) {
if (bcy >= 835) {
bcy = bcy;
} else {
bcy = bcy + 10;
}
}
}
public void keyTyped(KeyEvent ke) { }
public void keyReleased(KeyEvent ke) { }
public void move() {
// int s=Game.speed;
Thread t1 = new Thread() {
public void run() {
while (true) {
int s = Game.speed;
Random rand = new Random();
while (true) {
Game.rn1 = rand.nextInt(5) + 1;
if ((Game.rn1 != Game.rn2) && (Game.rn1 != Game.rn3) && (Game.rn1 != Game.rn4)
&& (Game.rn1 != Game.rn5)) {
break;
}
}
if (Game.rn1 == 1) {
Game.score++;
Game.stat = true;
oc1y = Game.o1y;
while (oc1y < 1000) {
oc1y++;
repaint();
try {
Thread.sleep(s);
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
}
}
}
if (Game.rn1 == 2) {
Game.score++;
Game.stat = true;
oc2y = Game.o2y;
while (oc2y < 1000) {
oc2y++;
repaint();
try {
Thread.sleep(s);
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
}
}
}
if (Game.rn1 == 3) {
Game.score++;
Game.stat = true;
oc3y = Game.o3y;
while (oc3y < 1000) {
oc3y++;
repaint();
try {
Thread.sleep(s);
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
}
}
}
if (Game.rn1 == 4) {
Game.score++;
Game.stat = true;
oc4y = Game.o4y;
while (oc4y < 1000) {
oc4y++;
repaint();
try {
Thread.sleep(s);
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
}
}
}
if (Game.rn1 == 5) {
Game.score++;
Game.stat = true;
oc5y = Game.o5y;
while (oc5y < 1000) {
oc5y++;
repaint();
try {
Thread.sleep(s);
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
}
}
}
}
}
};
t1.start();
// t2.start();
// t3.start();
// t4.start();
// t5.start();
}
}
Game
public class Game {
static int bx;
static int by;
static int o1x;
static int o1y;
static int o2x;
static int o2y;
static int o3x;
static int o3y;
static int o4x;
static int o4y;
static int o5x;
static int o5y;
static int rn1;
static int rn2;
static int rn3;
static int rn4;
static int rn5;
static int speed = 10;
static int score = 0;
static boolean stat;
public static void main(String[] args) {
bx = 473;
by = 830;
o1x = 293;
o1y = 0;
o2x = 383;
o2y = 0;
o3x = 473;
o3y = 0;
o4x = 563;
o4y = 0;
o5x = 653;
o5y = 0;
Frame f = new Frame();
}
}
Solution
Your logic should not be cluttered in your frame, you should move that logic into a panel. The frame is just the container that holds your game together.
The main issue with your flickering is that you are using paint instead of paintComponent.
Also, you should try to utilize arrays instead of separate int variables. This way you can performs loops and shorten the length of your code by 75% or more.
Lastly, load your car images only once. You should not be loading them each time you redraw.
Game
import javax.swing.JFrame;
import javax.swing.SwingUtilities;
public class Game implements Runnable {
static int bx;
static int by;
static int o1x;
static int o1y;
static int o2x;
static int o2y;
static int o3x;
static int o3y;
static int o4x;
static int o4y;
static int o5x;
static int o5y;
static int rn1;
static int rn2;
static int rn3;
static int rn4;
static int rn5;
static int speed = 10;
static int score = 0;
static boolean stat;
public static void main(String[] args) {
bx = 473;
by = 830;
o1x = 293;
o1y = 0;
o2x = 383;
o2y = 0;
o3x = 473;
o3y = 0;
o4x = 563;
o4y = 0;
o5x = 653;
o5y = 0;
SwingUtilities.invokeLater(new Game());;
}
@Override
public void run() {
GameFrame f = new GameFrame();
GamePanel p = new GamePanel();
f.setContentPane(p);
f.setVisible(true);
f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
p.setFocusable(true);
p.requestFocusInWindow();
p.move();
}
}
GameFrame
import java.awt.FlowLayout;
import javax.swing.JFrame;
public class GameFrame extends JFrame {
private static final long serialVersionUID = -5151041547543472432L;
public GameFrame() {
super("Clash101");
setSize(1000, 1000);
setLayout(new FlowLayout());
// setFocusable(true);
}
}
GamePanel
import java.awt.Color;
import java.awt.Graphics;
import java.awt.Image;
import java.awt.Label;
import java.awt.Rectangle;
import java.awt.Toolkit;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
import java.util.Random;
import javax.swing.JPanel;
public class GamePanel extends JPanel implements KeyListener {
private static final long serialVersionUID = -3415101101924291007L;
int bcx = Game.bx;
int bcy = Game.by;
int oc1x = Game.o1x;
int oc1y = Game.o1y;
int oc2x = Game.o2x;
int oc2y = Game.o2y;
int oc3x = Game.o3x;
int oc3y = Game.o3y;
int oc4x = Game.o4x;
int oc4y = Game.o4y;
int oc5x = Game.o5x;
int oc5y = Game.o5y;
Rectangle rbc, roc1, roc2, roc3, roc4, roc5, rs1, rs2, rs3;
Image blueCar, orangeCar;
public GamePanel() {
super();
Toolkit t = Toolkit.getDefaultToolkit();
blueCar = t.getImage(getClass().getClassLoader().getResource("resources/blue_car.png").getPath());
orangeCar = t.getImage(getClass().getClassLoader().getResource("resources/orange_car.png").getPath());
addKeyListener(this);
}
public void move() {
// int s=Game.speed;
Thread t1 = new Thread() {
public void run() {
while (true) {
int s = Game.speed;
Random rand = new Random();
while (true) {
Game.rn1 = rand.nextInt(5) + 1;
if ((Game.rn1 != Game.rn2) && (Game.rn1 != Game.rn3) && (Game.rn1 != Game.rn4)
&& (Game.rn1 != Game.rn5)) {
break;
}
}
if (Game.rn1 == 1) {
Game.score++;
Game.stat = true;
oc1y = Game.o1y;
while (oc1y < 1000) {
oc1y++;
repaint();
try {
Thread.sleep(s);
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
}
}
}
if (Game.rn1 == 2) {
Game.score++;
Game.stat = true;
oc2y = Game.o2y;
while (oc2y < 1000) {
oc2y++;
repaint();
try {
Thread.sleep(s);
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
}
}
}
if (Game.rn1 == 3) {
Game.score++;
Game.stat = true;
oc3y = Game.o3y;
while (oc3y < 1000) {
oc3y++;
repaint();
try {
Thread.sleep(s);
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
}
}
}
if (Game.rn1 == 4) {
Game.score++;
Game.stat = true;
oc4y = Game.o4y;
while (oc4y < 1000) {
oc4y++;
repaint();
try {
Thread.sleep(s);
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
}
}
}
if (Game.rn1 == 5) {
Game.score++;
Game.stat = true;
oc5y = Game.o5y;
while (oc5y < 1000) {
oc5y++;
repaint();
try {
Thread.sleep(s);
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
}
}
}
}
}
};
t1.start();
// t2.start();
// t3.start();
// t4.start();
// t5.start();
}
public void keyPressed(KeyEvent e) {
System.out.println("Key...");
int key = e.getKeyCode();
if (key == KeyEvent.VK_LEFT) {
bcx = bcx - 10;
}
if (key == KeyEvent.VK_RIGHT) {
bcx = bcx + 10;
}
if (key == KeyEvent.VK_UP) {
bcy = bcy - 10;
}
if (key == KeyEvent.VK_DOWN) {
if (bcy >= 835) {
bcy = bcy;
} else {
bcy = bcy + 10;
}
}
}
public void keyTyped(KeyEvent e) { }
public void keyReleased(KeyEvent e) { }
public void paintComponent(Graphics g) {
super.paintComponent(g);
if ((Game.score % 5 == 0) && (Game.speed > 1) && (Game.stat == true)) {
Game.speed--;
Game.stat = false;
}
rbc = new Rectangle(bcx, bcy, 55, 105);
roc1 = new Rectangle(oc1x, oc1y, 55, 105);
roc2 = new Rectangle(oc2x, oc2y, 55, 105);
roc3 = new Rectangle(oc3x, oc3y, 55, 105);
roc4 = new Rectangle(oc4x, oc4y, 55, 105);
roc5 = new Rectangle(oc5x, oc5y, 55, 105);
rs1 = new Rectangle(275, 70, 451, 30);
rs2 = new Rectangle(245, 70, 30, 910);
rs3 = new Rectangle(726, 70, 30, 910);
if ((rbc.intersects(roc1) == true) || (rbc.intersects(roc2) == true) || (rbc.intersects(roc3) == true)
|| (rbc.intersects(roc4) == true) || (rbc.intersects(roc5) == true) || (rbc.intersects(rs1) == true)
|| (rbc.intersects(rs2) == true) || (rbc.intersects(rs3) == true)) {
System.out.println("Collision");
System.out.println("Score: " + Game.score);
System.out.println("Speed: " + Game.speed);
System.exit(0);
}
g.setColor(Color.WHITE);
g.fillRect(0, 0, 1000, 1000);
g.setColor(Color.BLACK);
g.drawRect(275, 100, 450, 850);
g.drawRect(365, 100, 90, 850);
g.drawRect(545, 100, 90, 850);
if ((Game.rn1 == 1) || (Game.rn2 == 1) || (Game.rn3 == 1) || (Game.rn4 == 1) || (Game.rn5 == 1)) {
g.drawImage(orangeCar, oc1x, oc1y, this);
}
if ((Game.rn1 == 2) || (Game.rn2 == 2) || (Game.rn3 == 2) || (Game.rn4 == 2) || (Game.rn5 == 2)) {
g.drawImage(orangeCar, oc2x, oc2y, this);
}
if ((Game.rn1 == 3) || (Game.rn2 == 3) || (Game.rn3 == 3) || (Game.rn4 == 3) || (Game.rn5 == 3)) {
g.drawImage(orangeCar, oc3x, oc3y, this);
}
if ((Game.rn1 == 4) || (Game.rn2 == 4) || (Game.rn3 == 4) || (Game.rn4 == 4) || (Game.rn5 == 4)) {
g.drawImage(orangeCar, oc4x, oc4y, this);
}
if ((Game.rn1 == 5) || (Game.rn2 == 5) || (Game.rn3 == 5) || (Game.rn4 == 5) || (Game.rn5 == 5)) {
g.drawImage(orangeCar, oc5x, oc5y, this);
}
g.drawImage(blueCar, bcx, bcy, this);
g.setColor(Color.BLACK);
g.fillRect(275, 70, 451, 30);
g.fillRect(275, 950, 451, 30);
g.fillRect(245, 70, 30, 910);
g.fillRect(726, 70, 30, 910);
g.setColor(Color.WHITE);
g.fillRect(275, 980, 451, 100);
g.fillRect(275, 0, 451, 69);
g.setColor(Color.BLACK);
g.drawString("Score: " + Game.score, 50, 50);
}
}
Here is a screenshot.
And here are the assets:
Note: I used this image and changed the colors before exporting to PNG.
- Keep numbers which appear in both columns, in J lang
- Differentiation in J
- How to reshape an array with an arbitrary size in one dimension?
- Why is Insert (fold) right associative
- Write 4 : 'x&{.&.;: y' tacitly
- Alignment issue when printing formatted prime numbers in J language
- How can I define a verb in J that applies a different verb alternately to each atom in a list?
- How to get user input in the J programming language
- How to unbox a list of boxed lists of differing lengths in J?
- How can I fix 'noun result was required' error in J?
- In j, how can I define a verb locally in one scope and pass it to a defined adverb?
- Convert boxed array to normal array?
- Read column of CSV file as array
- Replace atom in array of strings
- What does the dyad `=` do to boxed strings?
- Index of minimum element using J
- How can I take the outer product of string vectors in J?
- Building an array of verbs in J
- Reading in multidigit command line parameter
- Amend with bond to new data shows unexpected behaviour
- How to turn a table or matrix into a (flat) list in J
- How to run dissect in J?
- How to define selection using index function in J
- How to exit the J console?
- Find 4-neighbors using J
- Writing custom verbs in J
- How do I negate a selector in J lang?
- How to use arbitrary selector in interchange in J lang?
- different result once square root is added inside tacit
- Sum of arrays with repeated indices