Search code examples
c++fizzbuzz

Why does this C++ prime checker and summer return wrong results?


I don't get why the summation never works properly, yet sums consistently. It dosent throw any errors, but never gets the correct result. According to wolfram|alpha i can be off with as much as 20 000 000 000 for large calculations. I have no idea why this happens, so any ideas you might have are greatly appreciated! Note: Compiled with -O3 and -std=c++14 flags.

Code:

#include "stdafx.h"
#include <math.h>
#include <vector>
#include <stdio.h>
#include <iostream>
typedef unsigned long long ul;
const ul PRIMES = 1000000;
bool isPrime(ul n)
{
    if (n <= 1) return false;
    double sqN = sqrt(n);
    for (ul i = 3; i <= sqN; i++) {
        if ((int)n % i == 0) return false;
    } return true;
}
int main()
{
    std::vector<ul> primes;
    ul sumPrimes = 0;
    ul numPrimes = 0;
    for (ul n = 2; n <= PRIMES; n++) if (isPrime(n)) primes.push_back(n);
    numPrimes = primes.size();
    for (ul sp : primes) sumPrimes += sp;
    std::vector<ul> fizz, buzz, fizzbuzz;
    ul sumF = 0, sumB = 0, sumFB = 0;
    ul numF = 0, numB = 0, numFB = 0;
    for (ul prime = 0; prime < primes.size(); prime++) {
        if (prime % 15 == 0) {
            fizzbuzz.push_back(primes[prime]);
        }
        else if (prime % 5 == 0) {
            buzz.push_back(primes[prime]);
        }
        else if (prime % 3 == 0) {
            fizz.push_back(primes[prime]);
        }
    }
    for (ul fb : fizzbuzz) sumFB += fb;
    for (ul f : fizz) sumF += f;
    for (ul b : buzz) sumB += b;
    numF = fizz.size(); numB = buzz.size(); numFB = fizzbuzz.size();
    std::cout << "Stats for primes upto\t" << PRIMES << "\n";
    std::cout << "Primecount:\t\t" << numPrimes << "\n";
    std::cout << "Sum Primes:\t\t" << sumPrimes << "\n";
    std::cout << "Fizzcount:\t\t" << numF << "\n";
    std::cout << "Sum Fizz:\t\t" << sumF << "\n";
    std::cout << "Buzzcount:\t\t" << numB << "\n";
    std::cout << "Sum Buzz:\t\t" << sumB << "\n";
    std::cout << "FizzBuzzcount:\t\t" << numFB << "\n";
    std::cout << "Sum FizzBuzz:\t\t" << sumFB << "\n";
    std::system("pause");
    return 0;
}

And this is the output i get: output


Solution

  • In your isPrime method, you are starting with i = 3. Start with i = 2 so that you are removing non primes that have a factor of 2.

    bool isPrime(ul n)
    {
        if (n <= 1) return false;
        double sqN = sqrt(n);
        for (ul i = 3; i <= sqN; i++) {
            if ((int)n % i == 0) return false;
        } return true;
    }
    

    Try

    bool isPrime(ul n)
    {
        if (n <= 1) return false;
        double sqN = sqrt(n);
        for (ul i = 2; i <= sqN; i++) {
            if ((int)n % i == 0) return false;
        } return true;
    }
    

    Unless I have misunderstood something.