Search code examples
cstringhashstring-conversionhash-function

Conversion from string to long int returns same value for different strings


I've been trying to convert a char* type c string to a long integer in order to use the converted number as a key value to a hash function. I tried both atol and strtol functions, and both return to me the same hash value everytime I call the function with a different string.The following is my hash function.

int h_function(char* key,h_table* table){
    int i; 
    char* key_i=key;
    char str[14];
    char code[4];
    char number[11];
    long result;
    //printf("%c\n",key_i[13]);
    //there is a "-" in  key[3] so i want to remove that first
    for(i=0;i<3;i++){
        code[i]=key_i[i];
    }
    code[3]='\0';
    printf("This is the code: %s\n",code);
    for(i=0;i<10;i++){
        number[i]=key_i[i+4];
    }
    number[10]='\0';
    printf("This is the number: %s\n",number);
    strcpy(str,code);
    strcat(str,number);
    printf("This is the full key number: %s\n",str);
    //converting to long int
    result=atol(str);
    printf("This is the key converted to an integer: %ld\n",result);
    int hash_value=(result % table->size);
    printf("The hashvalue is: %d\n",hash_value);
    return hash_value;
}

And this is the output I get:

This is the code: 357
This is the number: 5472318696
This is the full key number: 3575472318696
This is the key converted to an integer: 2147483647
The hashvalue is: 22
This is the hashed index: 22

Even though the full key number changes according to the char* key i pass as an argument, the converted integer stays the same as well as the hash value. I would appreciate any sort of help...thanks in advance.


Solution

  • That's because 3575472318696 does not fit in an int or long (which I assume are 32 bits on your implementation).

    It looks like it returns the maximum long value in that case, 2^31 - 1 = 2147483647.