How can I clean up my MediaPlayer after use?

Question

Is this the correct way to use the MediaPlayer?

public class MainActivity extends AppCompatActivity{


        MediaPlayer sound1, sound2, sound3, sound4;

        @Override
        protected void onCreate(Bundle savedInstanceState) {
            super.onCreate(savedInstanceState);
            setContentView(R.layout.activity_main);


            //Sound MediaPlayers
            sound1= MediaPlayer.create(this, R.raw.sound1);
            sound2= MediaPlayer.create(this, R.raw.sound2);
            sound3= MediaPlayer.create(this, R.raw.sound3);
            sound4= MediaPlayer.create(this, R.raw.sound4);

        }


    //sound onClick's 
    public void sound1(View view){
        sound1.start();
    }
    public void sound2(View view){
        sound2.start();
    }
    public void sound3(View view){
        sound3.start();
    }
    public void sound4(View view){
        sound4.start();
    }

}

I have to clean up the MediaPlayer, but I don't know how I can do that. I know that I have to use sound1.release() but it doesn't work if I write:

public void sound1(View view){
            sound1.start();
            sound1.release();
        }

Please give me an example.

Answer 1

This should do the work for you.

public class MainActivity extends AppCompatActivity{


    MediaPlayer mediaPlayer;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
    }


    //sound onClick's 
    public void sound1(View view){
        cleanUpMediaPlayer();
        mediaPlayer = MediaPlayer.create(this, R.raw.sound1);
        mediaPlayer.start();
    }

    public void sound2(View view){
        cleanUpMediaPlayer();
        mediaPlayer = MediaPlayer.create(this, R.raw.sound2);
        mediaPlayer.start();
    }

    public void sound3(View view){
        cleanUpMediaPlayer();
        mediaPlayer = MediaPlayer.create(this, R.raw.sound3);
        mediaPlayer.start();
    }

    public void sound4(View view){
        cleanUpMediaPlayer();
        mediaPlayer = MediaPlayer.create(this, R.raw.sound4);
        mediaPlayer.start();
    }

    public void cleanUpMediaPlayer(){
        if(mediaPlayer != null) {
            if(mediaPlayer.isPlaying()) {
                mediaPlayer.stop();
            }
            mediaPlayer.release();
        }
    }

}