How can I distinguish my characters in a vector? SFML 2.4.1

Question

I am using push_back to add identical characters and for some reason these characters all have the same stats all the time.

Battle.cpp:

void Battle::InitalizeUser() 
{

    user.t_Pokemon.clear();
    user.t_Item.clear();

    user.currentPokemon_U = 0;

    user.t_Pokemon.push_back(&uF1);
    user.t_Pokemon.push_back(&uF1);
    user.t_Pokemon.push_back(&uW3);
    user.t_Pokemon.push_back(&uW3);
    user.t_Pokemon.push_back(&uG5);
    user.t_Pokemon.push_back(&uG5);

    user.t_Item.push_back(&uI1);
    user.t_Item.push_back(&uI2);

    for (unsigned int i = 0; i < user.t_Pokemon.size(); i++)
    {
        user.t_Pokemon.at(i)->poke_health = 100;
        user.t_Pokemon.at(i)->poke_isFainted = false;
    }

    assert(user.t_Pokemon.size() == 6);

    assert(user.t_Item.size() == 2);
}

So if uF1 health is reduced all uF1 characters will suffer the same reduction, but I don't want all the others uF1 to suffer the reduction, I want to be able to distinguish them and have only one specific character affected.

How can I do that?

Pokemon.cpp:

void Pokemon::attackNormal(Pokemon * opponentPokemon)
{

    opponentPokemon->poke_health = opponentPokemon->poke_health - 20;
    opponentPokemon->changeIfFainted();

    assert(opponentPokemon->poke_health <= 100 && opponentPokemon->poke_health >= 0);

}

Battle.h:

class Battle

{ private:

static Trainer user;
static Trainer ash;


static IntRect user_Rect;
static IntRect ash_Rect;

// User's pokemon
static Fire uF1;
static Water uW3;
static Grass uG5;
static Item uI1;
static Item uI2;

}

uF1 : Pokemon.h

   class Fire : public Pokemon 

{

public:
 Fire(); 
 Fire(string name); 
 virtual ~Fire();
void specialAttack(Pokemon * opponentPokemon);
void changeWeather();
void Draw(RenderWindow &window);

};

Answer 1

The problem is that your vector contains copies of a pointer what is not equivalent to having different copies of an actual object.

It seems that you are passing same pointers several times in order to achieve object copy which is not a case.

You should first declare all your objects and then add their addresses to the vector.

Additional note: you don't have to create a variable for every object you use. You could also create an array of objects.