attempt to re-open an already-closed object: SQLiteDatabase error on first launch

Question

I am having a big problem with my database. When I try to make the first call to the database since the app launches, I get a crash saying: attempt to re-open an already-closed object: SQLiteDatabase /data/user/0/<path_to_db>

I am using a DBHelper class which extends SQLiteOpenHelper.

When I launch the app the first time, it should create the DB etc, and then have an empty DB which should still allow me to do some queries on it.

However, when I do my first query, it crashes with the above error. Here's the query:

public TerminalList getTerminalLocations() {
    SQLiteDatabase db = getReadableDatabase();
    Cursor cursor = db.query(LOCATION_TABLE_NAME, null, null, null, null, null, null);
    //do stuff
    cursor.close();
    db.close();

    return locationList;
}

Its crashing on the first line!! SQLiteDatabase db = getReadableDatabase();

It doesn't even get as far as the cursor! How is this possible? Does anyone know how to fix this?

Does it make a difference that this is being called from the OnCreateView of my fragment? Here is how I call it. Its pretty standard:

private void getLocations() {
    DBHelper db = DBHelper.getInstance(getActivity());
    TerminalList locations = db.getTerminalLocations();
    //do stuff
}

I've tried commenting out this call, but it pushes the problem to the next DB call, so is happening with every single DB call in the app!!

Thanks.

Answer 1

Try something like this for the utility method:

public Cursor getWhatyouNeed(SQLiteDatabase db, params...) {
    Cursor yourData = db.query(your_query_params...);
    // your logic
    return yourData;
}