is valid Mvp pattern implementation (with rxandroid and retrofit)

Question

I want to get data from remote server using rxandroid in mvp repository. Then,set up grid adapter with data(in Fragment), and replace another fragment for tablet ui(in Activity).

If I use callback listener I need at least 2 callbacks, which to notify async(rxjava) is done to fragment and launch fragment with first record from data set.

Is there alternative way to solve this problem other than callback ??

Actually I am not even sure if I am using rxjava properly.

For now I pass observable back to fragment in order to set adapter and launch new fragment from that returned data.

 public <T> Observable.Transformer<T, T> applySchedulers() {
    return observable -> observable
            .subscribeOn(Schedulers.io())
            .observeOn(AndroidSchedulers.mainThread());
}

@Override
public Observable<MovieDataContainer> getMovieByFilter(String sortBy, String apiKey, int number) {
    MovieApiService movieApiService= retrofit.createService(MovieApiService.class);
    return movieApiService
            .getMovieList(sortBy,apiKey,number)
            .compose(applySchedulers());
}

If I am not doing correct way please let me know. If you have sample for this case, it will be grateful

Just in case here is mygit repo

Answer 1

I would create these components:

• ItemsView and ItemsPresenter for displaying items list.
• DetailsView and DetailsPresenter for displaying item details.
• NavigationHelper for managing navigation (eg. open new fragment)

Flow will look like this:

1. ItemsPresenter.loadData() loads data using rxJava and retrofit.
2. ItemsPresenter calls ItemsView.showItems(List<Items> list) (inside you will have something like (adapter.setContent(list))
3. ItemsPresenter calls NavigationHelper.showDetails(Item selectedItem). NavigationHelper should behave differently depending on phone/tablet.

ItemsPresenter could behave differently for phone and for tablet. For phone it calls NavigationHelper.showDetails only when user selects item from a list. For table it calls NavigationHelper.showDetails also for a first item when data is loaded. I suggest to pass knowledge about phone/table via presenter's constructor.

For example of ItemsPresenter -> ItemsView flow see Presenter and View implementation