Search code examples
javaswingfocusjradiobuttonbuttongroup

Get the focus in a ButtonGroup of JRadioButtons to go to the currently selected item instead of first


I have some JRadioButtons in a ButtonGroup. These are all inside of a container, and there are other items on the group. Whenever I tab to the button group, the focus always goes to the first item in the group. However, I would much rather it go to the item that is selected.

To reproduce the problem, use the code below (add the imports, and for now ignore the fact that I was too lazy to put it all in a SwingUtilities.invokeLater call). Tab down to the radio buttons, and then arrow down to one of the later items, such as Blue. Tab 4 more times to get back to the radio buttons, and you will find the focus on the top "Red" radio button. I would like the focus to be on the "Blue" radio button.

public static void main(String[] args)
{
    JFrame f = new JFrame("JRadioButton Test");
    f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    Container parent = f.getContentPane();
    parent.setLayout(new GridBagLayout());

    GridBagConstraints gbc = new GridBagConstraints();
    gbc.anchor = GridBagConstraints.NORTHWEST;
    gbc.gridx = 1;
    gbc.gridy = 1;
    parent.add(new JLabel("Start"), gbc);
    gbc.gridx++;
    parent.add(new JTextField(10), gbc);

    gbc.gridx = 1;
    gbc.gridy++;
    parent.add(new JLabel("End"), gbc);
    gbc.gridx++;
    parent.add(new JTextField(10), gbc);

    gbc.gridx = 1;
    gbc.gridy++;
    parent.add(new JLabel("Colors"), gbc);

    gbc.gridx++;
    final Box buttons = Box.createVerticalBox();
    parent.add(buttons, gbc);
    final ButtonGroup bg = new ButtonGroup();
    for (String s : "Red,Orange,Yellow,Green,Blue,Indigo,Violet".split(","))
    {
        JRadioButton radioBtn = new JRadioButton(s);
        buttons.add(radioBtn);
        radioBtn.addItemListener(new ItemListener() {
            @Override
            public void itemStateChanged(ItemEvent e)
            {
                System.out.printf("Itemstate changed to %s\n",
                    e.getStateChange() == ItemEvent.SELECTED ? "SELECTED" : "DESELECTED");
            }
        });
        radioBtn.addActionListener(new ActionListener() {
            @Override
            public void actionPerformed(ActionEvent e)
            {
                System.out.println("JRadioButton action listener");
            }
        });
        bg.add(radioBtn);
    }

    gbc.gridx = 1;
    gbc.gridy += 2;
    gbc.gridwidth = 2;
    final JLabel currentValue = new JLabel("none");
    parent.add(currentValue, gbc);
    gbc.gridy--;
    JButton btn = new JButton("Show Button Group Value");
    btn.addActionListener(new ActionListener() {
        @Override
        public void actionPerformed(ActionEvent e)
        {
            ButtonModel selection = bg.getSelection();
            for (int i = 0; i < buttons.getComponentCount(); i++)
            {
                JRadioButton radioBtn = (JRadioButton)buttons.getComponent(i);
                ButtonModel loopModel = radioBtn.getModel();
                if (loopModel == selection)
                {
                    currentValue.setText(radioBtn.getText());
                    return;
                }
                currentValue.setText("none");
            }
        }
    });
    parent.add(btn, gbc);

    f.pack();
    f.setVisible(true);
}

Solution

  • You might be able to use a FocusTraversalPolicy:

    buttons.setFocusTraversalPolicyProvider(true);
    buttons.setFocusTraversalPolicy(new LayoutFocusTraversalPolicy() {
      @Override public Component getDefaultComponent(Container focusCycleRoot) {
        ButtonModel selection = bg.getSelection();
        for (Component c: focusCycleRoot.getComponents()) {
          JRadioButton radioBtn = (JRadioButton) c;
          ButtonModel loopModel = radioBtn.getModel();
          if (loopModel == selection) {
            return radioBtn;
          }
        }
        return super.getDefaultComponent(focusCycleRoot);
      }
    });
    
    import java.awt.*;
    import java.awt.event.*;
    import javax.swing.*;
    
    public class ButtonGroupFocusTraversalTest {
      public JComponent makeUI() {
        JPanel parent = new JPanel(new GridBagLayout());
        GridBagConstraints gbc = new GridBagConstraints();
        gbc.anchor = GridBagConstraints.NORTHWEST;
        gbc.gridx = 1;
        gbc.gridy = 1;
        parent.add(new JLabel("Start"), gbc);
        gbc.gridx++;
        parent.add(new JTextField(10), gbc);
    
        gbc.gridx = 1;
        gbc.gridy++;
        parent.add(new JLabel("End"), gbc);
        gbc.gridx++;
        JTextField textField = new JTextField(10);
        parent.add(textField, gbc);
    
        gbc.gridx = 1;
        gbc.gridy++;
        parent.add(new JLabel("Colors"), gbc);
    
        gbc.gridx++;
        final Box buttons = Box.createVerticalBox();
        parent.add(buttons, gbc);
        final ButtonGroup bg = new ButtonGroup();
        for (String s : "Red,Orange,Yellow,Green,Blue,Indigo,Violet".split(",")) {
          JRadioButton radioBtn = new JRadioButton(s);
          buttons.add(radioBtn);
          bg.add(radioBtn);
        }
    
        gbc.gridx = 1;
        gbc.gridy += 2;
        gbc.gridwidth = 2;
        final JLabel currentValue = new JLabel("none");
        parent.add(currentValue, gbc);
        gbc.gridy--;
        JButton btn = new JButton("Show Button Group Value");
        parent.add(btn, gbc);
    
        buttons.setFocusTraversalPolicyProvider(true);
        buttons.setFocusTraversalPolicy(new LayoutFocusTraversalPolicy() {
          @Override public Component getDefaultComponent(Container focusCycleRoot) {
            ButtonModel selection = bg.getSelection();
            for (Component c: focusCycleRoot.getComponents()) {
              JRadioButton radioBtn = (JRadioButton) c;
              ButtonModel loopModel = radioBtn.getModel();
              if (loopModel == selection) {
                return radioBtn;
              }
            }
            return super.getDefaultComponent(focusCycleRoot);
          }
        });
        return parent;
      }
      public static void main(String... args) {
        EventQueue.invokeLater(() -> {
          JFrame f = new JFrame();
          f.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
          f.getContentPane().add(new ButtonGroupFocusTraversalTest().makeUI());
          f.setSize(320, 320);
          f.setLocationRelativeTo(null);
          f.setVisible(true);
        });
      }
    }