I am new to android dev and I am trying to create multi pane for large screen.It has 3 fragments.If I keep 2 fragments everything is fine.Third Review Fragment has Http Call.Issue Issue I am facing is I am not able to display review fragment below detail fragment.
1.Since I'm calling updateView method directly ,All members variables are not initialized though they are assigned in onCreateView method
2.so I am reassigning using getview() ,but I am not getting screen though adapter count is greater than 0. Code is working as desired in mobile activity_main.xml
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:baselineAligned="false"
android:divider="?android:attr/dividerHorizontal"
android:orientation="horizontal"
>
<!--
This layout is a two-pane layout for the Items master/detail flow.
-->
<fragment
android:id="@+id/fragment_forecast"
android:name="com.example.android.app.popularmovies.fragmetns.MovieGridFragment"
android:layout_width="wrap_content"
android:layout_height="match_parent"
android:layout_weight="2"
tools:layout="@layout/movie_grid_fragment" />
<LinearLayout
android:layout_width="wrap_content"
android:layout_weight="1"
android:layout_height="match_parent"
android:orientation="vertical"
>
<FrameLayout
android:id="@+id/movie_detail_activity"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:visibility="invisible"
/>
<FrameLayout
android:id="@+id/movie_review"
android:layout_width="match_parent"
android:layout_height="wrap_content"
/>
</LinearLayout>
</LinearLayout>
ReviewFragmenent Class
public class MovieReviewFragment extends Fragment {
private ProgressBar progressBar;
private RecyclerView mRecyclerView;
private RecyclerView.Adapter mAdapter;
private RecyclerView.LayoutManager mLayoutManager;
private List<MovieReview> movieReviewList;
private static final String LOG_TAG = MovieReviewFragment.class.getSimpleName();
@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
if (savedInstanceState != null && savedInstanceState.containsKey("REVIEW_DATA")) {
movieReviewList = savedInstanceState.getParcelableArrayList("REVIEW_DATA");
} else {
movieReviewList = new ArrayList<>();
}
}
@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
Bundle savedInstanceState) {
View rootView = inflater.inflate(R.layout.movie_review, container, false);
Intent intent = getActivity().getIntent();
if (intent != null && intent.hasExtra(PopularMovieConstants.MOVIE_DATA)) {
MovieDetails movieDetails = intent.getParcelableExtra(PopularMovieConstants.MOVIE_DATA);
// initUI(rootView);
progressBar = ((ProgressBar) rootView.findViewById(R.id.reviewProgessBar));
mRecyclerView = (RecyclerView) rootView.findViewById(R.id.MovieReviewView);
mRecyclerView.setHasFixedSize(true);
mLayoutManager = new LinearLayoutManager(getContext());
mRecyclerView.setLayoutManager(mLayoutManager);
mAdapter = new MovieReviewListAdapter(movieReviewList);
mRecyclerView.setAdapter(mAdapter);
if (mAdapter.getItemCount() == 0) {
getReview(movieDetails);
} else {
progressBar.setVisibility(View.GONE);
}
}
return rootView;
}
public void initUI(View view) {
Log.d(LOG_TAG,"start initView");
progressBar = ((ProgressBar) view.findViewById(R.id.reviewProgessBar));
mRecyclerView = (RecyclerView) view.findViewById(R.id.MovieReviewView);
mRecyclerView.setHasFixedSize(true);
mLayoutManager = new LinearLayoutManager(getContext());
mRecyclerView.setLayoutManager(mLayoutManager);
mAdapter = new MovieReviewListAdapter(movieReviewList);
mRecyclerView.setAdapter(mAdapter);
}
public void updateView(MovieDetails MovieDetails) {
//initUI(getView());
progressBar=(ProgressBar)getView().findViewById(R.id.reviewProgessBar);
mRecyclerView=(RecyclerView) getView().findViewById(R.id.MovieReviewView);
mRecyclerView.setHasFixedSize(true);
mLayoutManager = new LinearLayoutManager(getContext());
mRecyclerView.setLayoutManager(mLayoutManager);
mAdapter = new MovieReviewListAdapter(new ArrayList<MovieReview>());
mRecyclerView.setAdapter(mAdapter);
getReview(MovieDetails);
Log.d(LOG_TAG,"update View Completed");
}
public void getReview(MovieDetails MovieDetails) {
Log.d(LOG_TAG, "updateView MovieReviewFragment");
Uri builtUri = Uri.parse(PopularMovieConstants.BASE_URL)
.buildUpon()
.appendPath(PopularMovieConstants.MOVIE_APPENDER)
.appendPath(PopularMovieConstants.MOVIE_PATH)
.appendPath(Integer.toString(MovieDetails.getId()))
.appendPath(PopularMovieConstants.REVIEWS)
.appendQueryParameter(PopularMovieConstants.API_KEY_PARAM, BuildConfig.THE_MOVIE_DB_API_KEY)
.build();
Log.d(LOG_TAG, builtUri.toString());
Request request = new Request.Builder()
.url(builtUri.toString())
.build();
OkHttpClient client = new OkHttpClient();
client.newCall(request).enqueue(new Callback() {
@Override
public void onFailure(Request request, IOException throwable) {
throwable.printStackTrace();
}
@Override
public void onResponse(Response response) throws IOException {
if (!response.isSuccessful())
throw new IOException("Unexpected code " + response);
Gson gson = new Gson();
final MovieReviewsDTO reviews = gson.fromJson(response.body().charStream(), MovieReviewsDTO.class);
Log.d(LOG_TAG, "success");
getActivity().runOnUiThread(new Runnable() {
@Override
public void run() {
((MovieReviewListAdapter) mAdapter).setGridData(reviews.getResults());
Log.d(LOG_TAG, "ui" + ((MovieReviewListAdapter) mAdapter).getItemCount());
progressBar.setVisibility(View.GONE);
}
});
}
});
}
@Override
public void onSaveInstanceState(Bundle outState) {
outState.putParcelableArrayList("REVIEW_DATA"
, (ArrayList<? extends Parcelable>) ((MovieReviewListAdapter) mAdapter).getGridData());
super.onSaveInstanceState(outState);
}
}
I think the problem is with the Framelayout. Here is the statement from developer.android.com.
"FrameLayout is designed to block out an area on the screen to display a single item. Generally, FrameLayout should be used to hold a single child view, because it can be difficult to organize child views in a way that's scalable to different screen sizes without the children overlapping each other. You can, however, add multiple children to a FrameLayout and control their position within the FrameLayout by assigning gravity to each child, using the android:layout_gravity attribute. "
Change it to Relative layout and see if it's get displayed.