Search code examples
javascripthtmlangularjshtml-parsingangularjs-ng-init

Calling a init function when a directive is loaded


I have a simple directive that loads comments from a service(commentsService):

'use strict';

angular.module('mean.rank')
    .directive('commentList', function(CommentsService, Global) {
        return {
            restrict: 'E',
            templateUrl:  'rank/views/comments-list.html',
            replace: false,
            link: function($scope, element, attrs) {
                //accessing the ad info :  console.log("ADD  " , $scope.ad);
                $scope.comments = [];

                $scope.loadComments = function () {
                    console.log("in loadComments");
                    var adID = {};
                    adID.ad_ID = $scope.ad.nid;
                    console.log("calling services.getComments function with  " , adID.ad_ID);
                    CommentsService.getComments(adID.ad_ID)
                        .then(function (response) {
                            angular.forEach(comment in response)
                            $scope.comments.push(comment);
                        });


                };


            }
        }
    })

The loaded comments should be loaded to the list(inside the templateUrl) using ng-init and then the service for loading (I will add the code if needed).

<div ng-init="loadComments()">
    <ul class="media-list comment-detail-list" >
        <li class="media" ng-repeat="comment in comments" >
            <article>
                <div class="pull-left comment-info">
                    <a href="#" class="author">{{ comment.author }}</a><br />
                    <time>{{ comment.datePublished | date:"MM/dd/yyyy" }}</time>
                </div>
                <div class="media-body">
                    <div class="comment-body">
                        <p>{{ comment.comment }}</p>
                    </div>
                </div>
            </article>
        </li>
        <li>Debugger</li>
    </ul>
</div>

The directive has in its scope the loadCommets() function but it is not triggered. Thank's for your help!


Solution

  • I'd suggest putting the function call inside the link function itself instead of ng-init.

    angular.module('mean.rank')
        .directive('commentList', function(CommentsService, Global) {
            return {
                ...
                link: function($scope, element, attrs) {
                    //accessing the ad info :  console.log("ADD  " , $scope.ad);
                    $scope.comments = [];
    
                    $scope.loadComments = function () {
                        ...
                    };
    
                    $scope.loadComments();
                }
            }
        })
    

    Edit: by the way your forEach syntax is wrong. It should be

    angular.forEach(response, function(comment){
        $scope.comments.push(comment);
    });