Search code examples
androidandroid-viewpagerandroid-tabhost

TabHost is not working with view pager android


I am following this video to create my tabhost with navigation drawer and view pager,my page is sliding properly but after add tabhost,if i run my application it got crash,and giving nullpointer exception near this line

        tabhost.addTab(tabSpac);

MainActivity.java

public class MainActivity extends ActionBarActivity implements OnPageChangeListener,OnTabChangeListener{

    ViewPager viewpager;

    TabHost tabhost;
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);


        initViewpager();

        initTabhost();


    }



    private void initTabhost() {

        tabhost=(TabHost)findViewById(android.R.id.tabhost);
        tabhost.setup();

        String[] tabnames={"Tab1","Tab2","Tab3","Tab4","Tab5","Tab6"};

        for(int i=0;i<tabnames.length;i++)
        {
            TabHost.TabSpec tabSpac;
            tabSpac=tabhost.newTabSpec(tabnames[i]);
            tabSpac.setIndicator(tabnames[i]);
            tabSpac.setContent(new FakeContent(getApplicationContext()));
            tabhost.addTab(tabSpac);

        }

        tabhost.setOnTabChangedListener(this);
    }



    public class FakeContent implements TabContentFactory
    {
        Context context;
        public FakeContent (Context mcontext) {
            context=mcontext;
        }

        @Override
        public View createTabContent(String tag) {

            View fakeView=new View(context);
            fakeView.setMinimumHeight(0);
            fakeView.setMinimumWidth(0);
            return null;
        }

    }

    private void initViewpager() {
        viewpager=(ViewPager)findViewById(R.id.view_pager);
        List<Fragment> listFragments=new ArrayList<Fragment>();
        listFragments.add(new Fragment1());
        listFragments.add(new Fragment2());

        listFragments.add(new Fragment3());

        MyFragmentPagerAdapter myFragmentPagerAdapter = new MyFragmentPagerAdapter(getSupportFragmentManager(), listFragments);

        viewpager.setAdapter(myFragmentPagerAdapter);

        viewpager.setOnPageChangeListener(this);
    }
    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.main, menu);
        return true;
    }

    @Override
    public boolean onOptionsItemSelected(MenuItem item) {
        // Handle action bar item clicks here. The action bar will
        // automatically handle clicks on the Home/Up button, so long
        // as you specify a parent activity in AndroidManifest.xml.
        int id = item.getItemId();
        if (id == R.id.action_settings) {
            return true;
        }
        return super.onOptionsItemSelected(item);
    }



    @Override
    public void onTabChanged(String tabId) {
        // TODO Auto-generated method stub
        int selectedItem=tabhost.getCurrentTab();
        viewpager.setCurrentItem(selectedItem);

        HorizontalScrollView hscroolview=(HorizontalScrollView)findViewById(R.id.h_scrool_view);
        View tabView=tabhost.getCurrentTabView();
        int scrollPos=tabView.getLeft()-(hscroolview.getWidth()-tabView.getWidth())/2;
        hscroolview.smoothScrollTo(scrollPos, 0);

    }



    @Override
    public void onPageScrollStateChanged(int arg0) {
        // TODO Auto-generated method stub

    }



    @Override
    public void onPageScrolled(int arg0, float arg1, int arg2) {
        // TODO Auto-generated method stub

    }



    @Override
    public void onPageSelected(int selectedItem) {
        // TODO Auto-generated method stub
        tabhost.setCurrentTab(selectedItem);

    }


}

Log

10-24 18:38:13.091: E/AndroidRuntime(13748): FATAL EXCEPTION: main 10-24 18:38:13.091: E/AndroidRuntime(13748): java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.tabhostviewpagerslidingmenu/com.example.tabhostviewpagerslidingmenu.MainActivity}: java.lang.NullPointerException 10-24 18:38:13.091: E/AndroidRuntime(13748): at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1970) 10-24 18:38:13.091: E/AndroidRuntime(13748): at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:1995) 10-24 18:38:13.091: E/AndroidRuntime(13748): at android.app.ActivityThread.access$600(ActivityThread.java:128) 10-24 18:38:13.091: E/AndroidRuntime(13748): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1161) 10-24 18:38:13.091: E/AndroidRuntime(13748): at android.os.Handler.dispatchMessage(Handler.java:99) 10-24 18:38:13.091: E/AndroidRuntime(13748): at android.os.Looper.loop(Looper.java:137) 10-24 18:38:13.091: E/AndroidRuntime(13748): at android.app.ActivityThread.main(ActivityThread.java:4517) 10-24 18:38:13.091: E/AndroidRuntime(13748): at java.lang.reflect.Method.invokeNative(Native Method) 10-24 18:38:13.091: E/AndroidRuntime(13748): at java.lang.reflect.Method.invoke(Method.java:511) 10-24 18:38:13.091: E/AndroidRuntime(13748): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:993) 10-24 18:38:13.091: E/AndroidRuntime(13748): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:760) 10-24 18:38:13.091: E/AndroidRuntime(13748): at dalvik.system.NativeStart.main(Native Method) 10-24 18:38:13.091: E/AndroidRuntime(13748): Caused by: java.lang.NullPointerException 10-24 18:38:13.091: E/AndroidRuntime(13748): at android.widget.TabHost$FactoryContentStrategy.getContentView(TabHost.java:663) 10-24 18:38:13.091: E/AndroidRuntime(13748): at android.widget.TabHost.setCurrentTab(TabHost.java:356) 10-24 18:38:13.091: E/AndroidRuntime(13748): at android.widget.TabHost.addTab(TabHost.java:246) 10-24 18:38:13.091: E/AndroidRuntime(13748): at com.example.tabhostviewpagerslidingmenu.MainActivity.initTabhost(MainActivity.java:62) 10-24 18:38:13.091: E/AndroidRuntime(13748): at com.example.tabhostviewpagerslidingmenu.MainActivity.onCreate(MainActivity.java:42) 10-24 18:38:13.091: E/AndroidRuntime(13748): at android.app.Activity.performCreate(Activity.java:4470) 10-24 18:38:13.091: E/AndroidRuntime(13748): at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1053) 10-24 18:38:13.091: E/AndroidRuntime(13748): at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1934) 10-24 18:38:13.091: E/AndroidRuntime(13748): ... 11 more


Solution

  • Firstly you have a Reference Set as Null Which is causing this issue to occur.Secondly as said TabHost is depricated instead use Material TabLayout.

    Here is a Piece of Reference Code try this.

    ublic class SimpleTabsActivity extends AppCompatActivity {
    
    private Toolbar toolbar;
    private TabLayout tabLayout;
    private ViewPager viewPager;
    
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_simple_tabs);
    
        toolbar = (Toolbar) findViewById(R.id.toolbar);
        setSupportActionBar(toolbar);
    
        getSupportActionBar().setDisplayHomeAsUpEnabled(true);
    
        viewPager = (ViewPager) findViewById(R.id.viewpager);
        setupViewPager(viewPager);
    
        tabLayout = (TabLayout) findViewById(R.id.tabs);
        tabLayout.setupWithViewPager(viewPager);
    }
    
    private void setupViewPager(ViewPager viewPager) {
        ViewPagerAdapter adapter = new ViewPagerAdapter(getSupportFragmentManager());
        adapter.addFragment(new OneFragment(), "ONE");
        adapter.addFragment(new TwoFragment(), "TWO");
        adapter.addFragment(new ThreeFragment(), "THREE");
        viewPager.setAdapter(adapter);
    }
    
    class ViewPagerAdapter extends FragmentPagerAdapter {
        private final List<Fragment> mFragmentList = new ArrayList<>();
        private final List<String> mFragmentTitleList = new ArrayList<>();
    
        public ViewPagerAdapter(FragmentManager manager) {
            super(manager);
        }
    
        @Override
        public Fragment getItem(int position) {
            return mFragmentList.get(position);
        }
    
        @Override
        public int getCount() {
            return mFragmentList.size();
        }
    
        public void addFragment(Fragment fragment, String title) {
            mFragmentList.add(fragment);
            mFragmentTitleList.add(title);
        }
    
        @Override
        public CharSequence getPageTitle(int position) {
            return mFragmentTitleList.get(position);
        }
    }
    }
    

    Here is My XML Layout.

    <android.support.design.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    android:layout_width="match_parent"
    android:layout_height="match_parent">
    
    <android.support.design.widget.AppBarLayout
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:theme="@style/ThemeOverlay.AppCompat.Dark.ActionBar">
    
        <android.support.v7.widget.Toolbar
            android:id="@+id/toolbar"
            android:layout_width="match_parent"
            android:layout_height="?attr/actionBarSize"
            android:background="?attr/colorPrimary"
            app:layout_scrollFlags="scroll|enterAlways"
            app:popupTheme="@style/ThemeOverlay.AppCompat.Light" />
    
        <android.support.design.widget.TabLayout
            android:id="@+id/tabs"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            app:tabMode="fixed"
            app:tabGravity="fill"/>
    </android.support.design.widget.AppBarLayout>
    
    <android.support.v4.view.ViewPager
        android:id="@+id/viewpager"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        app:layout_behavior="@string/appbar_scrolling_view_behavior"/>