Search code examples
issue-tracking

Is there a guide or checklist for doing code reviews?


I've searched a little bit on the net to find a good guide on submitting and reviewing code reviews for my team.

Any help is appreciated.


Solution

    • Take your time to conduct the review.
    • The purpose of review is to carefully understand and analyze design and code. - Spend up to half the time on a review that you did writing the code or planning the design originally.
    • Let the reviewers drive the review.
    • The reviewers and their comments must drive a review. If developers are allowed to lead reviews of their own work, other reviewers might miss problems.
    • Read the code or design document before the review meeting.
    • Code sent for review is not sender.
    • You’ll always find somebody who knows better.
    • Challenge ideas but accept defeat gracefully.
    • Treat each other respectfully!!!
    • Track all issues found during code reviews.

    I've a blog post about code reviews: A guide for Code Reviews. Please read it.