Search code examples
androidbuttonheightwidth

Set button height equal to the button width


I've seen this question a lot on the internet, but all solutions didn't work for me..

So this is the problem. I want a button that has 50% width of the screen (that works fine).

But now I want it to have the same height the as the width.

Somehow this doesn't work:

Button button1 = (Button) findViewById(R.id.button1);
int btnSize = button1.getLayoutParams().width;
button1.setLayoutParams(new LinearLayout.LayoutParams(btnSize, btnSize));

See this for the code:

Activity1.java:

package nl.jesse.project1;

import android.app.Activity;
import android.os.Bundle;
import android.view.View;
import android.view.Menu;
import android.view.MenuItem;
import android.widget.Button;
import android.widget.LinearLayout;


public class Activity1 extends Activity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_activity1);

        Button button1 = (Button) findViewById(R.id.button1);
        int btnSize = button1.getLayoutParams().width;
        System.out.println(btnSize);
        //button1.setLayoutParams(new LinearLayout.LayoutParams(btnSize, btnSize));
    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.menu_activity1, menu);
        return true;
    }

    @Override
    public boolean onOptionsItemSelected(MenuItem item) {
        // Handle action bar item clicks here. The action bar will
        // automatically handle clicks on the Home/Up button, so long
        // as you specify a parent activity in AndroidManifest.xml.
        int id = item.getItemId();

        //noinspection SimplifiableIfStatement
        if (id == R.id.action_settings) {
            return true;
        }

        return super.onOptionsItemSelected(item);
    }

}

Activity_activity1.xml:

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".Activity1"
    android:weightSum="1.0" >


    <Button
        android:layout_height="wrap_content"
        android:layout_weight=".5"
        android:layout_width="0dip"
        android:text="@string/button1"
        android:id="@+id/button1" />

</LinearLayout>

I've already tried this and parts of it, without success.

So what am I doing wrong?


Solution

  • Ok I know this may not be the most efficient way to do it, but it is guaranteed to work.

    You create this ResizableButton class :

    import android.content.Context;
    import android.util.AttributeSet;
    import android.widget.Button;
    
    public class ResizableButton extends Button {
    
        public ResizableButton(Context context, AttributeSet attrs) {
            super(context, attrs);
        }
    
        @Override
        protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
            int width = MeasureSpec.getSize(widthMeasureSpec);
            setMeasuredDimension(width, width);
        }
    }
    

    and on your Activity_activity1.xml, you put :

    <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
        xmlns:tools="http://schemas.android.com/tools"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:weightSum="1.0"
        tools:context=".Activity1">
    
        <com.example.stackoverflow.ResizableButton
            android:id="@+id/button1"
            android:layout_width="0dip"
            android:layout_height="wrap_content"
            android:layout_weight=".5"
            android:text="Test" />
    
    </LinearLayout>
    

    Then you have a button that always has the same height as width and if you want to play with the button, on your main activity you will have to decalre a ResizableButton object and not a Button. Meaning :

     ResizableButton button1 = (ResizableButton) findViewById(R.id.button1);
    

    And Voilà.