Search code examples
javascriptjqueryonkeypress

Why I got wrong output in on this Javascript code?


I have 3 HTML input text and when I tried to type on paid input text I got correct answer only from 100 to 999 but when the total payable amount reach 1000+ it got wrong output.

Example:

Amount Payable: 500 (above 1000 has wrong output)

Paid: 600 <-- when I put 600 it has correct output to change, as long as it from 0 to 999 amount payable.

Change: 100 <-- Correct.

..but when the amount payable is higher than 999 it has wrong output.

Example:

Amount Payable: 1100

Paid: 1200

Change: 1199 <-- now I got wrong output. because the amount payable is above 1000.

This is my script:

$("#payable_form input").each(function(){
    $(this).keyup(function(){
       var payable_amount;
       var paid;

       payable_amount = parseFloat( $('#payable_amount').val() );
       paid = parseFloat( $('#paid').val() );
       payable_amount = $.isNumeric( payable_amount ) ? payable_amount : 0;
       paid = $.isNumeric(paid) ? paid : 0;

       var change = paid - payable_amount;
       $('#change').val(change.toFixed(2));
   });
});

FULL CODE:

<form class="form-horizontal" action="salestranslog.php" id="payable_form" method ="POST">
  <br />
    <div class="form-group">
      <label class="control-label col-xs-4">Customers:</label>
            <div class="col-xs-6">
        <?php  
             $result = mysqli_query($connection, "SELECT * FROM customers"); 
             echo "<select class='form-control' name='customer'>"; 
             while($row = mysqli_fetch_assoc($result)) 
             { 
                echo "<option value = '".$row[name]."'>".$row[name]."</option>"; 
             }
             echo "</select>"; 
        ?>
            </div>  
    </div>
    <div class="form-group form-group has-error has-feedback">
        <label class="control-label col-xs-4" for="amount">Total Payable Amount:</label>
        <div class="col-xs-4">
            <input type="text" class="form-control" id="payable_amount" name="payable_amount" value="<?php echo  number_format($total_sales,2); ?>"readonly>
            <span class="glyphicon glyphicon-info-sign form-control-feedback"></span>
        </div>
    </div>
    <div class="form-group">
        <label class="control-label col-xs-4" for="ttl_items">Total Purchase Items:</label>
        <label class="control-label col-xs-1" for="total_items"><mark><?php echo $count; ?></mark></label>
    </div>
        <div class="form-group">
      <label class="control-label col-xs-4">Paid by:</label>
            <div class="col-xs-6">
                <select class="form-control" name="cash">
                    <option>Cash</option>
                    <option>Cheque</option>
                </select>
            </div>  
    </div>

    <div class="form-group form-group-lg">
        <label class="control-label col-xs-4" for="paid">Paid:</label>
        <div class="col-xs-4">
            <input type="text" class="form-control" name="paid" id="paid" placeholder="0.00">
        </div>
    </div>
    <br /><br /><br />
    <div class="form-group has-warning has-feedback">
        <label class="control-label col-xs-4" for="ttl_items">Return Change:</label>
        <div class="col-xs-4">
            <input type="text" class="form-control" id="change" name="change" placeholder="0.00" readonly>
             <span class="glyphicon glyphicon-send form-control-feedback"></span>

        </div>
    </div>
    <br />
     </div>                     
    <script>
        $("#payable_form input").each(function(){
            $(this).keyup(function(){
            var payable_amount;
            var paid;
            payable_amount = parseFloat($('#payable_amount').val());
            paid = parseFloat($('#paid').val());
            payable_amount = $.isNumeric(payable_amount)?payable_amount:0;
            paid = $.isNumeric(paid)?paid:0;
            var change = paid - payable_amount;
            $('#change').val(change.toFixed(2));

        });
      });
    </script>

    <div class="modal-footer">
        <input type="submit" name="submit" value = "Submit" class="btn btn-success">
        <button type="button" class="btn btn-default" data-dismiss="modal">Close</button>
    </div>
</form>

Solution

  • number_format inserts a comma for numbers >= 1000

    number_format(1100, 2) prints "1,100.00"

    Running parseFloat("1,100.00") will output 1 and 1200 - 1 = 1199.

    This should work better with parseFloat:

    number_format($total_sales, 2, ".", "");