Search code examples
pythondjangogeneric-foreign-key

Filter Generic Foreign Key


Is there a more "Python/Django" way to query/filter objects by generic foreign key? I'm trying to get all FullCitation objects for a particular software, where is_primary is True.

I know I can't do this but I want to do something like this:

ct_supported = ContentType.objects.get(app_label="supportedprogram", model="software")
primary_citations = FullCitation.objects.filter(content_type__name=ct_supported, object_id__in='', is_primary=True)

models.py

class FullCitation(models.Model)
    # the software to which this citation belongs
    # either a supported software program or a non-supported software program

    limit = models.Q(app_label = 'myprograms', model = 'supportedprogram') | models.Q(app_label = 'myprograms', model = 'nonsupportedprogram') 
    content_type = models.ForeignKey(ContentType), limit_choices_to = limit, )
    object_id = models.PositiveIntegerField()
    content_object = generic.GenericForeignKey('content_type', 'object_id')

    is_primary = models.BooleanField(help_text="Is this the Primary Citation for the software program?")

class NonSupportedProgram(models.Model):
    title = models.CharField(max_length=256, blank = True)
    full_citation = generic.GenericRelation('FullCitation')

class SupportedProgram(models.Model):
    title = models.CharField(max_length=256, blank = True)
    full_citation = generic.GenericRelation('FullCitation')
    # and a bunch of other fields.....

views.py # My current attempt

primary_citations = []
sw_citations = sw.full_citations.all()
    for x in sw_citations:
        if x.is_primary:
            primary_citations.append(x)

Solution

  • Comprehensions should be a last resort for filtering QuerySets. Far better to let them remain as QuerySets as long as you can. I think this is what you're looking for:

    ct_supported = ContentType.objects.get_for_model(SupportedProgram))
    primary_citations = FullCitation.objects.filter(content_type=ct_supported, is_primary=True)
    

    Updated: If you want to filter for a specific SupportedProgram instance, do this:

    my_supported = SupportedProgram.objects.get(id=instance_id_goes_here)
    ct_supported = ContentType.objects.get_for_model(SupportedProgram))
    primary_citations = FullCitation.objects.filter(content_object=my_supported, content_type=ct_supported, is_primary=True)