I need help. I had a working website. The last step before going live was to update the ssl certificates. That did not happen due to a bug in that version of erlang. I upgraded erlang and then had a mismatch in code levels between erlang and the yaws driver. I donloaded and complied yaws and to my extreme pleasure I was able to update the ssl certificates. After starting the roll out, a user pointed out that the upload feature was not working. I verified that it still worked with the version that would not accept ssl cert. I assumed that the problem was in the build process, so I started over with a fresh VM of CentOS 7 and the erlang and Yaws from that distro. Same problem. It appears that I can have upload or new certs but not both. My version of the upload is a slightly modified version from the std upload.yaws. However, I picked that up and tried it. It also failed. Below is the software levels, the failing code and the crash data.
Any help will be greatly appreciated.
________Code _____________________________________________________________________ CentOS 3.10.0-123.6.3.el7.x86_64 erlang.x86_64 R16B-03.7.el7 @epel yaws.x86_64 1.98-2.el7 @epel
_CODE____________________________________________________________________________________________________________________________
-record(upload, { % represents state for a partially processed upload
fd,
filename,
last}).
-define(DIR, "/var/lib/yaws/www/cwfiles/").
showup(List) -> % Adds the rows of files from the DB
[{tr,[],[
{th,[], "File Name"}
]},
map(fun(Y) -> {TFid,FName} = Y, [
{tr,[],[
{td,[], [{input, [{type,text},{name,"Filename"},{value,FName}]}]},
{td,[], [{a,[{href,["dpagepost.yaws?action=delf& fid=",integer_to_list(TFid),"&fname=",[FName]]}],"Delete File"}]}
]}
] end, List)].
upload(A) -> upload(A,[]).
upload(A, Comment) ->
Css = css_head(A,on,57),
Body = case getadmen(A) of
true ->
Ref=dbconnect(),
{selected,_,LFil} = odbc:sql_query(Ref,"select fid,filename from files"),
odbc:disconnect(Ref),
{ehtml, [
{h2, [], "Update Files (Upload/Delete)"},
{hr},
{h3,[], [Comment]},
{hr},
{table, [], [
showup(LFil) % Do rows from DB
]}, %end table
{hr},
{form, [{enctype, "multipart/form-data"},{action," /dpagepost.yaws?action=addf"},{method,post}],[
{input, [{type,file},{name,"fname"},{width,"50"},{value,"Upload"}]},
{input, [{type,submit},{value,"Upload"}]}
]}
]};
_ ->
{ehtml, [
{h2, [], "Unvalid Action. Please insure you are Admin Enabled"},
{hr}
]}
end,
[Css, Body, bot(), break].
%%% Process POST data from client, state=#upload
%%% returns Ehtml | {get_more, Continuation, NewState}
uploadpost(A) ->
CAdmen = getadmen(A),
case {yaws_api:queryvar(A,"action"),CAdmen} of
{{ok, Action},true} -> Action;
_ -> Action = ""
end,
case Action of
"addf" ->
State = case A#arg.state of
undefined -> #upload{};
_ -> A#arg.state
end,
multipart(A, State);
"delf" ->
case {yaws_api:queryvar(A, "fid"),yaws_api:queryvar(A, "fname"),CAdmen} of
{{ok,LFid},{ok,LFname},true} ->
{NFid,_} = string:to_integer(LFid),
Fname = string:strip(LFname),
SQL = "delete from files where fid=?",
Ref=dbconnect(),
odbc:param_query(Ref,SQL,[{sql_integer, [NFid]}]),
odbc:disconnect(Ref),
case file:delete(concat(?DIR,Fname)) of
ok ->
upload(A,"File Delete sucessfull.");
_ -> upload(A,"File Delete Failed.")
end;
_ -> upload(A,"You performed an invalid Action.")
end;
_ -> upload(A,"You performed an invalid Action.")
end.
err() -> "error".
multipart(A, State) ->
Admen = getadmen(A),
Parse = yaws_api:parse_multipart_post(A),
case {Parse,Admen} of
{{cont, Cont, Res},true} ->
case addFileChunk(A, Res, State) of
{done, Result} ->
upload(A,Result);
{cont, NewState} ->
{get_more, Cont, NewState}
end;
{{result, Res},true} ->
case addFileChunk(A, Res, State#upload{last=true}) of
{done, Result} ->
upload(A,Result);
{cont, _} ->
upload(A,"Upload failed")
end;
_ ->
upload(A,"Upload failed")
end.
addFileChunk(A, [{part_body, Data}|Res], State) ->
addFileChunk(A, [{body, Data}|Res], State);
addFileChunk(_A, [], State) when State#upload.last==true,State#upload.filename /= undefined,State#upload.fd /= undefined ->
file:close(State#upload.fd),
SQL = "insert into files (filename) values ( ?)",
Ref=dbconnect(),
odbc:param_query(Ref,SQL,[{{sql_varchar, 50}, [State#upload.filename]}]),
odbc:disconnect(Ref),
{done,"Upload Completed Sucessfully."};
addFileChunk(_A, [], State) when State#upload.last==true ->
{done, err()};
addFileChunk(_A, [], State) ->
{cont, State};
addFileChunk(A, [{head, {_Name, Opts}}|Res], State ) ->
case lists:keysearch(filename, 1, Opts) of
{value, {_, Fname0}} ->
Fname = yaws_api:sanitize_file_name(filename:basename(Fname0)),
%file:make_dir(?DIR),
case file:open([?DIR, Fname] ,[write]) of
{ok, Fd} ->
S2 = State#upload{filename = Fname,fd = Fd},
addFileChunk(A, Res, S2);
_ ->
{done, err()}
end;
false -> addFileChunk(A,Res,State)
end;
addFileChunk(A, [{body, Data}|Res], State) when State#upload.filename /= undefined ->
case file:write(State#upload.fd, Data) of
ok ->
addFileChunk(A, Res, State);
_ ->
{done, err()}
end.`
_________Crash data_________________ Internal error, yaws code crashed
ERROR erlang code threw an uncaught exception:
File: /var/lib/yaws/www/dpagepost.yaws:1
Class: error
Exception: function_clause
Req: {http_request,'POST',{abs_path,"/dpagepost.yaws?action=addf"},{1,1}}
Stack: [{cwpage,addFileChunk,
[{arg,
{ssl,
{sslsocket,
{gen_tcp,#Port<0.1480>,tls_connection},
<0.73.0>}},
{{192,168,0,133},54630},
{headers,"keep-alive",
"text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8",
"192.168.0.190",undefined,undefined,undefined,undefined,
undefined,undefined,"https://192.168.0.190/upload.yaws",
"Mozilla/5.0 (X11; Linux x86_64; rv:26.0) Gecko/20100101 Firefox/26.0",
undefined,
["__atuvc=30%7C35; cwhoa_sid=nonode@nohost-211833414978628805947952202420298501124"],
undefined,undefined,"229",
"multipart/form-data; boundary=---------------------------501916758553745487488260262",
undefined,undefined,undefined,undefined,
[{http_header,10,'Accept-Encoding',undefined,
"gzip, deflate"},
{http_header,11,'Accept-Language',undefined,
"en-US,en;q=0.5"}]},
{http_request,'POST',
{abs_path,"/dpagepost.yaws?action=addf"},
{1,1}},
{http_request,'POST',
{abs_path,"/dpagepost.yaws?action=addf"},
{1,1}},
<<"-----------------------------501916758553745487488260262\r\nContent-Disposition: form-data; name=\"fname\"; filename=\"Hello.txt\"\r\nContent-Type: text/plain\r\n\r\nHello, World\n\r\n-----------------------------501916758553745487488260262--\r\n">>,
"/dpagepost.yaws","action=addf",undefined,
"/var/lib/yaws/www","/","/var/lib/yaws/www/dpagepost.yaws",
undefined,undefined,<0.72.0>,[],undefined,"/",undefined},
[{body,"Hello, World\n"}],
{upload,undefined,undefined,true}],
[{file,"cwpage.erl"},{line,239}]},
{cwpage,multipart,2,[{file,"cwpage.erl"},{line,209}]},
{yaws_server,deliver_dyn_part,8,
[{file,"yaws_server.erl"},{line,2801}]},
{yaws_server,aloop,4,[{file,"yaws_server.erl"},{line,1215}]},
{yaws_server,acceptor0,2,[{file,"yaws_server.erl"},{line,1052}]},
{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,239}]}]
I am sorry for only partial answer, but this is too long for a comment.
The error function_clause means, that non of the clauses matches given arguments.
addFileChunk(A, [{part_body, Data}|Res], State) -> ...
addFileChunk(_A, [], State) when State#upload.last==true,State#upload.filename /= undefined,State#upload.fd /= undefined -> ...
addFileChunk(_A, [], State) when State#upload.last==true -> ...
addFileChunk(_A, [], State) -> ...
addFileChunk(A, [{head, {_Name, Opts}}|Res], State ) -> ...
addFileChunk(A, [{body, Data}|Res], State) when State#upload.filename /= undefined -> ...
The first argument is unused or matches everything, so lets look at the other two.
[{body,"Hello, World\n"}],
{upload,undefined,undefined,true}
It could match the last clause, if there was a filename in upload record. So in uploadpost/1:
case Action of
"addf" ->
State = case A#arg.state of
undefined -> #upload{};
_ -> A#arg.state
end,
you could for example extract filename from arg.clidata and add it to upload state. This should solve the problem, but I have no idea, why it worked without SSL.